From 1192f309b016f78ea451844ed9c6ffb3f803fe20 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 25 Jun 2015 10:01:24 -0700
Subject: [PATCH] Fix an issue with handling of `null` feed URIs

Summary: Ref T8658. Caught this in the logs. This value may be set to `null`. Handle that gracefully.

Test Plan: Will check logs.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8658

Differential Revision: https://secure.phabricator.com/D13432
---
 .../feed/worker/FeedPublisherWorker.php         | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/applications/feed/worker/FeedPublisherWorker.php b/src/applications/feed/worker/FeedPublisherWorker.php
index 9d27722b59..0fc8171a49 100644
--- a/src/applications/feed/worker/FeedPublisherWorker.php
+++ b/src/applications/feed/worker/FeedPublisherWorker.php
@@ -6,13 +6,16 @@ final class FeedPublisherWorker extends FeedPushWorker {
     $story = $this->loadFeedStory();
 
     $uris = PhabricatorEnv::getEnvConfig('feed.http-hooks');
-    foreach ($uris as $uri) {
-      $this->queueTask(
-        'FeedPublisherHTTPWorker',
-        array(
-          'key' => $story->getChronologicalKey(),
-          'uri' => $uri,
-        ));
+
+    if ($uris) {
+      foreach ($uris as $uri) {
+        $this->queueTask(
+          'FeedPublisherHTTPWorker',
+          array(
+            'key' => $story->getChronologicalKey(),
+            'uri' => $uri,
+          ));
+      }
     }
 
     $argv = array(