From 11b8e57ae0122245419f730686aebb54f14a628c Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 17 Dec 2013 09:18:48 -0800
Subject: [PATCH] Remove "pretag" hook support in Mercurial

Summary: Ref T4195. This doesn't actually work like I thought it did: it only fires locally, when you run `hg tag`. Mercurial tags are also weird and basically don't make any sense and everyone should use bookmarks instead. We could implement some flavor of this eventually, but I'd like to see users request it first. They can implement their own with content-based hooks once those work, anyway.

Test Plan: This code didn't do anything.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4195

Differential Revision: https://secure.phabricator.com/D7765
---
 .../diffusion/engine/DiffusionCommitHookEngine.php          | 6 ------
 .../repository/engine/PhabricatorRepositoryPullEngine.php   | 6 ------
 2 files changed, 12 deletions(-)

diff --git a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
index c75c2b1866..99087aceed 100644
--- a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
+++ b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
@@ -432,8 +432,6 @@ final class DiffusionCommitHookEngine extends Phobject {
         return $this->findMercurialChangegroupRefUpdates();
       case 'prepushkey':
         return $this->findMercurialPushKeyRefUpdates();
-      case 'pretag':
-        return $this->findMercurialPreTagRefUpdates();
       default:
         throw new Exception(pht('Unrecognized hook "%s"!', $hook));
     }
@@ -693,10 +691,6 @@ final class DiffusionCommitHookEngine extends Phobject {
     return array($ref_update);
   }
 
-  private function findMercurialPreTagRefUpdates() {
-    return array();
-  }
-
   private function findMercurialContentUpdates(array $ref_updates) {
     // TODO: Implement.
     return array();
diff --git a/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php b/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
index 59be2016fd..b92696fde2 100644
--- a/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
+++ b/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
@@ -412,12 +412,6 @@ final class PhabricatorRepositoryPullEngine
       $repository->getCallsign(),
       'prepushkey');
 
-    // This one handles creating tags.
-    $data[] = csprintf(
-      'pretag.phabricator = %s %s %s',
-      $bin,
-      $repository->getCallsign(),
-      'pretag');
     $data[] = null;
 
     $data = implode("\n", $data);