revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

Fix some error log issues with uninitialized commit/revision lists

Browse source 
Summary:
Fixes T12679. Reproduction steps appear to be:

  - As a logged-out user, view revision list or commit list.
  - Enable bucketing by action required.
  - Before patch: `foreach (null as ...)` causes error spew.
  - After patch: `foreach (array() as ...)` works great.

Test Plan:
  - Reproduced issue by following steps above in Differential (revisions) and Diffusion (audits/commits).
  - After patches, no more errors in the log.

Reviewers: chad, amckinley

Reviewed By: chad

Maniphest Tasks: T12679

Differential Revision: https://secure.phabricator.com/D17872
This commit is contained in:
epriestley 2017-05-12 11:05:02 -07:00
parent db631b423f
commit 11c5638832
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/audit/view/PhabricatorAuditListView.php
View file

@ -2,7 +2,7 @@
final class PhabricatorAuditListView extends AphrontView { final class PhabricatorAuditListView extends AphrontView {
private $commits; private $commits = array();
private $header; private $header;
private $showDrafts; private $showDrafts;
private $noDataString; private $noDataString;

2
src/applications/differential/view/DifferentialRevisionListView.php
View file

@ -5,7 +5,7 @@
*/ */
final class DifferentialRevisionListView extends AphrontView { final class DifferentialRevisionListView extends AphrontView {
private $revisions; private $revisions = array();
private $handles; private $handles;
private $header; private $header;
private $noDataString; private $noDataString;