mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 05:50:55 +01:00
Fix some error log issues with uninitialized commit/revision lists
Summary: Fixes T12679. Reproduction steps appear to be: - As a logged-out user, view revision list or commit list. - Enable bucketing by action required. - Before patch: `foreach (null as ...)` causes error spew. - After patch: `foreach (array() as ...)` works great. Test Plan: - Reproduced issue by following steps above in Differential (revisions) and Diffusion (audits/commits). - After patches, no more errors in the log. Reviewers: chad, amckinley Reviewed By: chad Maniphest Tasks: T12679 Differential Revision: https://secure.phabricator.com/D17872
This commit is contained in:
parent
db631b423f
commit
11c5638832
2 changed files with 2 additions and 2 deletions
|
@ -2,7 +2,7 @@
|
|||
|
||||
final class PhabricatorAuditListView extends AphrontView {
|
||||
|
||||
private $commits;
|
||||
private $commits = array();
|
||||
private $header;
|
||||
private $showDrafts;
|
||||
private $noDataString;
|
||||
|
|
|
@ -5,7 +5,7 @@
|
|||
*/
|
||||
final class DifferentialRevisionListView extends AphrontView {
|
||||
|
||||
private $revisions;
|
||||
private $revisions = array();
|
||||
private $handles;
|
||||
private $header;
|
||||
private $noDataString;
|
||||
|
|
Loading…
Reference in a new issue