From 11cccb98c2becac8a5023911af430fd1a57695e6 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 13 Mar 2012 11:18:11 -0700 Subject: [PATCH] Add "final" to more classes Summary: No big surprises here, delted the unused "DarkConsole" class. Test Plan: Ran 'testEverythingImplemented' to verify I wasn't finalizing anything we extend. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T795 Differential Revision: https://secure.phabricator.com/D1876 --- src/__phutil_library_map__.php | 1 - src/aphront/console/api/DarkConsole.php | 24 ------------------- src/aphront/console/api/__init__.php | 10 -------- .../plugin/config/DarkConsoleConfigPlugin.php | 4 ++-- .../errorlog/DarkConsoleErrorLogPlugin.php | 4 ++-- .../api/DarkConsoleErrorLogPluginAPI.php | 4 ++-- .../plugin/event/DarkConsoleEventPlugin.php | 4 ++-- .../event/api/DarkConsoleEventPluginAPI.php | 4 ++-- .../request/DarkConsoleRequestPlugin.php | 4 ++-- .../services/DarkConsoleServicesPlugin.php | 2 +- .../plugin/xhprof/DarkConsoleXHProfPlugin.php | 4 ++-- .../exception/base/AphrontException.php | 4 ++-- .../exception/csrf/AphrontCSRFException.php | 4 ++-- .../redirect/AphrontRedirectException.php | 7 ++++-- src/aphront/request/AphrontRequest.php | 2 +- .../__tests__/AphrontRequestTestCase.php | 2 +- .../response/304/Aphront304Response.php | 4 ++-- .../response/400/Aphront400Response.php | 4 ++-- .../response/403/Aphront403Response.php | 2 +- .../response/404/Aphront404Response.php | 2 +- .../response/file/AphrontFileResponse.php | 2 +- .../plaintext/AphrontPlainTextResponse.php | 2 +- .../redirect/AphrontRedirectResponse.php | 4 +++- .../response/reload/AphrontReloadResponse.php | 4 ++-- .../webpage/AphrontWebpageResponse.php | 4 +++- .../auditcomment/PhabricatorAuditComment.php | 4 ++-- .../PhabricatorOAuthProviderFacebook.php | 2 +- .../github/PhabricatorOAuthProviderGitHub.php | 2 +- .../google/PhabricatorOAuthProviderGoogle.php | 2 +- .../PhabricatorOAuthFailureView.php | 2 +- ...ConduitAPI_arcanist_projectinfo_Method.php | 4 ++-- .../ConduitAPI_conduit_connect_Method.php | 4 ++-- ...nduitAPI_conduit_getcertificate_Method.php | 4 ++-- .../ping/ConduitAPI_conduit_ping_Method.php | 4 ++-- .../ConduitAPI_daemon_launched_Method.php | 4 ++-- .../log/ConduitAPI_daemon_log_Method.php | 4 ++-- ...tAPI_differential_createcomment_Method.php | 5 ++-- ...duitAPI_differential_creatediff_Method.php | 2 +- ...API_differential_createrevision_Method.php | 5 ++-- .../ConduitAPI_differential_find_Method.php | 2 +- ...uitAPI_differential_getalldiffs_Method.php | 5 ++-- ...I_differential_getcommitmessage_Method.php | 3 ++- ...API_differential_getcommitpaths_Method.php | 5 ++-- ...ConduitAPI_differential_getdiff_Method.php | 4 ++-- ...uitAPI_differential_getrevision_Method.php | 3 ++- ...ifferential_getrevisioncomments_Method.php | 4 ++-- ...ifferential_getrevisionfeedback_Method.php | 4 ++-- ...tAPI_differential_markcommitted_Method.php | 3 ++- ...differential_parsecommitmessage_Method.php | 2 +- .../ConduitAPI_differential_query_Method.php | 3 ++- ...PI_differential_setdiffproperty_Method.php | 5 ++-- ...API_differential_updaterevision_Method.php | 3 ++- ...rential_updatetaskrevisionassoc_Method.php | 4 ++-- ..._differential_updateunitresults_Method.php | 4 ++-- ...onduitAPI_diffusion_findsymbols_Method.php | 5 ++-- ...ConduitAPI_diffusion_getcommits_Method.php | 5 ++-- ...iffusion_getrecentcommitsbypath_Method.php | 4 ++-- .../ConduitAPI_feed_publish_Method.php | 5 ++-- .../ConduitAPI_file_download_Method.php | 5 ++-- .../file/info/ConduitAPI_file_info_Method.php | 4 ++-- .../upload/ConduitAPI_file_upload_Method.php | 4 ++-- ...I_maniphest_gettasktransactions_Method.php | 2 +- .../create/ConduitAPI_paste_create_Method.php | 4 ++-- .../info/ConduitAPI_paste_info_Method.php | 4 ++-- .../ConduitAPI_path_getowners_Method.php | 4 ++-- .../edit/ConduitAPI_phriction_edit_Method.php | 4 ++-- .../ConduitAPI_phriction_history_Method.php | 4 ++-- .../info/ConduitAPI_phriction_info_Method.php | 4 ++-- .../info/ConduitAPI_slowvote_info_Method.php | 4 ++-- .../protocol/exception/ConduitException.php | 4 ++-- .../protocol/request/ConduitAPIRequest.php | 2 +- .../protocol/response/ConduitAPIResponse.php | 2 +- .../PhabricatorConduitConnectionLog.php | 4 ++-- .../PhabricatorConduitCertificateToken.php | 4 ++-- .../storage/timer/PhabricatorTimer.php | 4 ++-- .../DifferentialRevisionListData.php | 2 +- .../comment/DifferentialCommentEditor.php | 2 +- .../revision/DifferentialRevisionEditor.php | 2 +- .../DifferentialFieldValidationException.php | 4 ++-- .../ccwelcome/DifferentialCCWelcomeMail.php | 4 ++-- .../mail/comment/DifferentialCommentMail.php | 2 +- .../DifferentialDiffContentMail.php | 4 ++-- .../exception/DifferentialExceptionMail.php | 4 ++-- .../mail/newdiff/DifferentialNewDiffMail.php | 4 ++-- .../changeset/DifferentialChangesetParser.php | 2 +- .../replyhandler/DifferentialReplyHandler.php | 2 +- .../changeset/DifferentialChangeset.php | 2 +- .../storage/comment/DifferentialComment.php | 2 +- .../storage/diff/DifferentialDiff.php | 2 +- .../diffproperty/DifferentialDiffProperty.php | 4 ++-- .../storage/hunk/DifferentialHunk.php | 4 ++-- .../DifferentialInlineComment.php | 2 +- .../storage/revision/DifferentialRevision.php | 2 +- .../DifferentialChangesetDetailView.php | 2 +- .../DifferentialChangesetListView.php | 2 +- .../base/DiffusionPathChangeQuery.php | 4 ++-- .../request/base/DiffusionRequest.php | 6 ++++- .../request/git/DiffusionGitRequest.php | 4 ++-- .../mercurial/DiffusionMercurialRequest.php | 4 ++-- .../request/svn/DiffusionSvnRequest.php | 4 ++-- .../category/PhabricatorDirectoryCategory.php | 4 ++-- .../storage/item/PhabricatorDirectoryItem.php | 4 ++-- .../storage/base/PhabricatorDraftDAO.php | 4 ++-- .../draft/storage/draft/PhabricatorDraft.php | 4 ++-- .../ec2host/DrydockEC2HostBlueprint.php | 2 +- .../remotehost/DrydockRemoteHostBlueprint.php | 3 +++ .../drydock/storage/base/DrydockDAO.php | 2 +- .../drydock/storage/lease/DrydockLease.php | 2 +- .../storage/resource/DrydockResource.php | 2 +- .../feed/storage/base/PhabricatorFeedDAO.php | 4 ++-- .../story/PhabricatorFeedStoryData.php | 2 +- .../PhabricatorFeedStoryReference.php | 4 ++-- .../PhabricatorFeedStoryDifferential.php | 2 +- .../PhabricatorFeedStoryManiphest.php | 2 +- .../PhabricatorFeedStoryPhriction.php | 2 +- .../project/PhabricatorFeedStoryProject.php | 2 +- .../status/PhabricatorFeedStoryStatus.php | 2 +- .../unknown/PhabricatorFeedStoryUnknown.php | 4 ++-- .../view/story/PhabricatorFeedStoryView.php | 4 ++-- .../files/storage/base/PhabricatorFileDAO.php | 4 ++-- .../files/storage/file/PhabricatorFile.php | 2 +- .../imagemacro/PhabricatorFileImageMacro.php | 4 ++-- .../proxyimage/PhabricatorFileProxyImage.php | 4 ++-- .../PhabricatorFileStorageBlob.php | 4 ++-- .../PhabricatorTransformedFile.php | 4 ++-- .../phriction/controller/diff/__init__.php | 2 +- 126 files changed, 222 insertions(+), 229 deletions(-) delete mode 100644 src/aphront/console/api/DarkConsole.php delete mode 100644 src/aphront/console/api/__init__.php diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php index 974efc3ad3..21a6e2fdc0 100644 --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -169,7 +169,6 @@ phutil_register_library_map(array( 'ConduitAPI_user_info_Method' => 'applications/conduit/method/user/info', 'ConduitAPI_user_whoami_Method' => 'applications/conduit/method/user/whoami', 'ConduitException' => 'applications/conduit/protocol/exception', - 'DarkConsole' => 'aphront/console/api', 'DarkConsoleConfigPlugin' => 'aphront/console/plugin/config', 'DarkConsoleController' => 'aphront/console/controller', 'DarkConsoleCore' => 'aphront/console/core', diff --git a/src/aphront/console/api/DarkConsole.php b/src/aphront/console/api/DarkConsole.php deleted file mode 100644 index 24dcfd2851..0000000000 --- a/src/aphront/console/api/DarkConsole.php +++ /dev/null @@ -1,24 +0,0 @@ -getData()); diff --git a/src/aphront/console/plugin/errorlog/api/DarkConsoleErrorLogPluginAPI.php b/src/aphront/console/plugin/errorlog/api/DarkConsoleErrorLogPluginAPI.php index d56799c24c..98d1801596 100644 --- a/src/aphront/console/plugin/errorlog/api/DarkConsoleErrorLogPluginAPI.php +++ b/src/aphront/console/plugin/errorlog/api/DarkConsoleErrorLogPluginAPI.php @@ -1,7 +1,7 @@ content = $content; diff --git a/src/aphront/response/redirect/AphrontRedirectResponse.php b/src/aphront/response/redirect/AphrontRedirectResponse.php index 1b3ea3031e..d51631125c 100644 --- a/src/aphront/response/redirect/AphrontRedirectResponse.php +++ b/src/aphront/response/redirect/AphrontRedirectResponse.php @@ -1,7 +1,7 @@ getRequest()->isAjax()) { diff --git a/src/aphront/response/webpage/AphrontWebpageResponse.php b/src/aphront/response/webpage/AphrontWebpageResponse.php index 9bdb6f6f92..c94b400357 100644 --- a/src/aphront/response/webpage/AphrontWebpageResponse.php +++ b/src/aphront/response/webpage/AphrontWebpageResponse.php @@ -1,7 +1,7 @@ getRevision(); diff --git a/src/applications/differential/mail/comment/DifferentialCommentMail.php b/src/applications/differential/mail/comment/DifferentialCommentMail.php index 397ecd5f2e..0889e05325 100644 --- a/src/applications/differential/mail/comment/DifferentialCommentMail.php +++ b/src/applications/differential/mail/comment/DifferentialCommentMail.php @@ -16,7 +16,7 @@ * limitations under the License. */ -class DifferentialCommentMail extends DifferentialMail { +final class DifferentialCommentMail extends DifferentialMail { protected $changedByCommit; diff --git a/src/applications/differential/mail/diffcontent/DifferentialDiffContentMail.php b/src/applications/differential/mail/diffcontent/DifferentialDiffContentMail.php index 82dfc390a3..f021ae4d2f 100644 --- a/src/applications/differential/mail/diffcontent/DifferentialDiffContentMail.php +++ b/src/applications/differential/mail/diffcontent/DifferentialDiffContentMail.php @@ -1,7 +1,7 @@ getRevision(); diff --git a/src/applications/differential/parser/changeset/DifferentialChangesetParser.php b/src/applications/differential/parser/changeset/DifferentialChangesetParser.php index 8ce058604d..a74979437d 100644 --- a/src/applications/differential/parser/changeset/DifferentialChangesetParser.php +++ b/src/applications/differential/parser/changeset/DifferentialChangesetParser.php @@ -16,7 +16,7 @@ * limitations under the License. */ -class DifferentialChangesetParser { +final class DifferentialChangesetParser { protected $visible = array(); protected $new = array(); diff --git a/src/applications/differential/replyhandler/DifferentialReplyHandler.php b/src/applications/differential/replyhandler/DifferentialReplyHandler.php index b16dbde854..9c2441c89b 100644 --- a/src/applications/differential/replyhandler/DifferentialReplyHandler.php +++ b/src/applications/differential/replyhandler/DifferentialReplyHandler.php @@ -16,7 +16,7 @@ * limitations under the License. */ -class DifferentialReplyHandler extends PhabricatorMailReplyHandler { +final class DifferentialReplyHandler extends PhabricatorMailReplyHandler { private $receivedMail; diff --git a/src/applications/differential/storage/changeset/DifferentialChangeset.php b/src/applications/differential/storage/changeset/DifferentialChangeset.php index 66518d4e07..20eadd08d4 100644 --- a/src/applications/differential/storage/changeset/DifferentialChangeset.php +++ b/src/applications/differential/storage/changeset/DifferentialChangeset.php @@ -16,7 +16,7 @@ * limitations under the License. */ -class DifferentialChangeset extends DifferentialDAO { +final class DifferentialChangeset extends DifferentialDAO { protected $diffID; protected $oldFile; diff --git a/src/applications/differential/storage/comment/DifferentialComment.php b/src/applications/differential/storage/comment/DifferentialComment.php index ece26c42ce..3e59d9e7d3 100644 --- a/src/applications/differential/storage/comment/DifferentialComment.php +++ b/src/applications/differential/storage/comment/DifferentialComment.php @@ -16,7 +16,7 @@ * limitations under the License. */ -class DifferentialComment extends DifferentialDAO { +final class DifferentialComment extends DifferentialDAO { const METADATA_ADDED_REVIEWERS = 'added-reviewers'; const METADATA_ADDED_CCS = 'added-ccs'; diff --git a/src/applications/differential/storage/diff/DifferentialDiff.php b/src/applications/differential/storage/diff/DifferentialDiff.php index 47e95a54b0..5a04f8de35 100644 --- a/src/applications/differential/storage/diff/DifferentialDiff.php +++ b/src/applications/differential/storage/diff/DifferentialDiff.php @@ -16,7 +16,7 @@ * limitations under the License. */ -class DifferentialDiff extends DifferentialDAO { +final class DifferentialDiff extends DifferentialDAO { protected $revisionID; protected $authorPHID; diff --git a/src/applications/differential/storage/diffproperty/DifferentialDiffProperty.php b/src/applications/differential/storage/diffproperty/DifferentialDiffProperty.php index e70e95f9f6..91365b5b22 100644 --- a/src/applications/differential/storage/diffproperty/DifferentialDiffProperty.php +++ b/src/applications/differential/storage/diffproperty/DifferentialDiffProperty.php @@ -1,7 +1,7 @@ getStoryData(); diff --git a/src/applications/feed/story/maniphest/PhabricatorFeedStoryManiphest.php b/src/applications/feed/story/maniphest/PhabricatorFeedStoryManiphest.php index 4aaaf7d1fd..c16afa5ff4 100644 --- a/src/applications/feed/story/maniphest/PhabricatorFeedStoryManiphest.php +++ b/src/applications/feed/story/maniphest/PhabricatorFeedStoryManiphest.php @@ -16,7 +16,7 @@ * limitations under the License. */ -class PhabricatorFeedStoryManiphest extends PhabricatorFeedStory { +final class PhabricatorFeedStoryManiphest extends PhabricatorFeedStory { public function getRequiredHandlePHIDs() { $data = $this->getStoryData(); diff --git a/src/applications/feed/story/phriction/PhabricatorFeedStoryPhriction.php b/src/applications/feed/story/phriction/PhabricatorFeedStoryPhriction.php index 35867a0d9a..0f03fdc304 100644 --- a/src/applications/feed/story/phriction/PhabricatorFeedStoryPhriction.php +++ b/src/applications/feed/story/phriction/PhabricatorFeedStoryPhriction.php @@ -16,7 +16,7 @@ * limitations under the License. */ -class PhabricatorFeedStoryPhriction extends PhabricatorFeedStory { +final class PhabricatorFeedStoryPhriction extends PhabricatorFeedStory { public function getRequiredHandlePHIDs() { return array( diff --git a/src/applications/feed/story/project/PhabricatorFeedStoryProject.php b/src/applications/feed/story/project/PhabricatorFeedStoryProject.php index 89b0c413dc..382a531c32 100644 --- a/src/applications/feed/story/project/PhabricatorFeedStoryProject.php +++ b/src/applications/feed/story/project/PhabricatorFeedStoryProject.php @@ -16,7 +16,7 @@ * limitations under the License. */ -class PhabricatorFeedStoryProject extends PhabricatorFeedStory { +final class PhabricatorFeedStoryProject extends PhabricatorFeedStory { public function getRequiredHandlePHIDs() { return array( diff --git a/src/applications/feed/story/status/PhabricatorFeedStoryStatus.php b/src/applications/feed/story/status/PhabricatorFeedStoryStatus.php index 4550b653dc..d08719685f 100644 --- a/src/applications/feed/story/status/PhabricatorFeedStoryStatus.php +++ b/src/applications/feed/story/status/PhabricatorFeedStoryStatus.php @@ -16,7 +16,7 @@ * limitations under the License. */ -class PhabricatorFeedStoryStatus extends PhabricatorFeedStory { +final class PhabricatorFeedStoryStatus extends PhabricatorFeedStory { public function getRequiredHandlePHIDs() { return array( diff --git a/src/applications/feed/story/unknown/PhabricatorFeedStoryUnknown.php b/src/applications/feed/story/unknown/PhabricatorFeedStoryUnknown.php index 60d828de0d..fc084831c3 100644 --- a/src/applications/feed/story/unknown/PhabricatorFeedStoryUnknown.php +++ b/src/applications/feed/story/unknown/PhabricatorFeedStoryUnknown.php @@ -1,7 +1,7 @@ getStoryData(); diff --git a/src/applications/feed/view/story/PhabricatorFeedStoryView.php b/src/applications/feed/view/story/PhabricatorFeedStoryView.php index 4998052fbc..65b133c34d 100644 --- a/src/applications/feed/view/story/PhabricatorFeedStoryView.php +++ b/src/applications/feed/view/story/PhabricatorFeedStoryView.php @@ -1,7 +1,7 @@