From 11cf8f05b176f4f911675d023285b0fb35e7f01f Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 20 Dec 2018 10:41:01 -0800 Subject: [PATCH] Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface Summary: Depends on D19919. Ref T11351. This method appeared in D8802 (note that "get...Object" was renamed to "get...Transaction" there, so this method was actually "new" even though a method of the same name had existed before). The goal at the time was to let Harbormaster post build results to Diffs and have them end up on Revisions, but this eventually got a better implementation (see below) where the Harbormaster-specific code can just specify a "publishable object" where build results should go. The new `get...Object` semantics ultimately broke some stuff, and the actual implementation in Differential was removed in D10911, so this method hasn't really served a purpose since December 2014. I think that broke the Harbormaster thing by accident and we just lived with it for a bit, then Harbormaster got some more work and D17139 introduced "publishable" objects which was a better approach. This was later refined by D19281. So: the original problem (sending build results to the right place) has a good solution now, this method hasn't done anything for 4 years, and it was probably a bad idea in the first place since it's pretty weird/surprising/fragile. Note that `Comment` objects still have an unrelated method with the same name. In that case, the method ties the `Comment` storage object to the related `Transaction` storage object. Test Plan: Grepped for `getApplicationTransactionObject`, verified that all remaining callsites are related to `Comment` objects. Reviewers: amckinley Reviewed By: amckinley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T11351 Differential Revision: https://secure.phabricator.com/D19920 --- .../almanac/storage/AlmanacBinding.php | 4 ---- .../almanac/storage/AlmanacDevice.php | 4 ---- .../almanac/storage/AlmanacInterface.php | 4 ---- .../almanac/storage/AlmanacNamespace.php | 4 ---- .../almanac/storage/AlmanacNetwork.php | 4 ---- .../almanac/storage/AlmanacService.php | 4 ---- .../auth/storage/PhabricatorAuthPassword.php | 4 ---- .../storage/PhabricatorAuthProviderConfig.php | 4 ---- .../auth/storage/PhabricatorAuthSSHKey.php | 4 ---- .../badges/storage/PhabricatorBadgesBadge.php | 4 ---- src/applications/base/PhabricatorApplication.php | 4 ---- .../calendar/storage/PhabricatorCalendarEvent.php | 4 ---- .../storage/PhabricatorCalendarExport.php | 4 ---- .../storage/PhabricatorCalendarImport.php | 4 ---- .../config/storage/PhabricatorConfigEntry.php | 4 ---- .../conpherence/storage/ConpherenceThread.php | 4 ---- .../countdown/storage/PhabricatorCountdown.php | 4 ---- .../dashboard/storage/PhabricatorDashboard.php | 4 ---- .../storage/PhabricatorDashboardPanel.php | 4 ---- .../differential/storage/DifferentialDiff.php | 4 ---- .../differential/storage/DifferentialRevision.php | 4 ---- .../diviner/storage/DivinerLiveBook.php | 4 ---- .../drydock/storage/DrydockBlueprint.php | 4 ---- .../files/storage/PhabricatorFile.php | 4 ---- src/applications/fund/storage/FundBacker.php | 4 ---- src/applications/fund/storage/FundInitiative.php | 4 ---- .../engine/HarbormasterBuildableEngine.php | 4 +--- .../storage/HarbormasterBuildable.php | 4 ---- .../storage/build/HarbormasterBuild.php | 4 ---- .../configuration/HarbormasterBuildPlan.php | 4 ---- .../configuration/HarbormasterBuildStep.php | 4 ---- src/applications/herald/storage/HeraldRule.php | 4 ---- src/applications/herald/storage/HeraldWebhook.php | 4 ---- .../legalpad/storage/LegalpadDocument.php | 4 ---- .../macro/storage/PhabricatorFileImageMacro.php | 4 ---- .../maniphest/storage/ManiphestTask.php | 4 ---- .../PhabricatorMetaMTAApplicationEmail.php | 4 ---- src/applications/nuance/storage/NuanceItem.php | 4 ---- src/applications/nuance/storage/NuanceQueue.php | 4 ---- src/applications/nuance/storage/NuanceSource.php | 4 ---- .../storage/PhabricatorOAuthServerClient.php | 4 ---- .../owners/storage/PhabricatorOwnersPackage.php | 4 ---- .../storage/PhabricatorPackagesPackage.php | 4 ---- .../storage/PhabricatorPackagesPublisher.php | 4 ---- .../storage/PhabricatorPackagesVersion.php | 4 ---- .../passphrase/storage/PassphraseCredential.php | 4 ---- .../paste/storage/PhabricatorPaste.php | 4 ---- .../people/storage/PhabricatorUser.php | 4 ---- src/applications/phame/storage/PhameBlog.php | 4 ---- src/applications/phame/storage/PhamePost.php | 4 ---- src/applications/phlux/storage/PhluxVariable.php | 4 ---- src/applications/pholio/storage/PholioMock.php | 4 ---- .../phortune/storage/PhortuneAccount.php | 4 ---- .../phortune/storage/PhortuneCart.php | 4 ---- .../phortune/storage/PhortuneMerchant.php | 4 ---- .../storage/PhortunePaymentProviderConfig.php | 4 ---- .../phriction/storage/PhrictionDocument.php | 4 ---- .../phurl/storage/PhabricatorPhurlURL.php | 4 ---- src/applications/ponder/storage/PonderAnswer.php | 4 ---- .../ponder/storage/PonderQuestion.php | 4 ---- .../project/storage/PhabricatorProject.php | 4 ---- .../project/storage/PhabricatorProjectColumn.php | 4 ---- .../releeph/storage/ReleephBranch.php | 4 ---- .../releeph/storage/ReleephProject.php | 4 ---- .../releeph/storage/ReleephRequest.php | 4 ---- .../repository/storage/PhabricatorRepository.php | 4 ---- .../storage/PhabricatorRepositoryCommit.php | 4 ---- .../storage/PhabricatorRepositoryIdentity.php | 4 ---- .../storage/PhabricatorRepositoryURI.php | 4 ---- .../PhabricatorProfileMenuItemConfiguration.php | 4 ---- .../storage/PhabricatorUserPreferences.php | 4 ---- .../slowvote/storage/PhabricatorSlowvotePoll.php | 4 ---- .../spaces/storage/PhabricatorSpacesNamespace.php | 4 ---- .../PhabricatorSubscriptionsEditController.php | 4 +--- .../PhabricatorSubscriptionsMuteController.php | 4 +--- .../tokens/editor/PhabricatorTokenGivenEditor.php | 4 +--- .../PhabricatorApplicationTransactionEditor.php | 3 +-- ...PhabricatorApplicationTransactionInterface.php | 15 --------------- ...bricatorApplicationTransactionReplyHandler.php | 4 +--- .../PhabricatorEditEngineConfiguration.php | 4 ---- .../workers/storage/PhabricatorWorkerBulkJob.php | 4 ---- 81 files changed, 6 insertions(+), 328 deletions(-) diff --git a/src/applications/almanac/storage/AlmanacBinding.php b/src/applications/almanac/storage/AlmanacBinding.php index 5577ee5e7d..a7096fc51f 100644 --- a/src/applications/almanac/storage/AlmanacBinding.php +++ b/src/applications/almanac/storage/AlmanacBinding.php @@ -206,10 +206,6 @@ final class AlmanacBinding return new AlmanacBindingEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacBindingTransaction(); } diff --git a/src/applications/almanac/storage/AlmanacDevice.php b/src/applications/almanac/storage/AlmanacDevice.php index f25b2eb5a1..1d1010733a 100644 --- a/src/applications/almanac/storage/AlmanacDevice.php +++ b/src/applications/almanac/storage/AlmanacDevice.php @@ -204,10 +204,6 @@ final class AlmanacDevice return new AlmanacDeviceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacDeviceTransaction(); } diff --git a/src/applications/almanac/storage/AlmanacInterface.php b/src/applications/almanac/storage/AlmanacInterface.php index 9a5023e751..6cd318186f 100644 --- a/src/applications/almanac/storage/AlmanacInterface.php +++ b/src/applications/almanac/storage/AlmanacInterface.php @@ -168,10 +168,6 @@ final class AlmanacInterface return new AlmanacInterfaceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacInterfaceTransaction(); } diff --git a/src/applications/almanac/storage/AlmanacNamespace.php b/src/applications/almanac/storage/AlmanacNamespace.php index 0c8f0c5ec7..128cfdb72e 100644 --- a/src/applications/almanac/storage/AlmanacNamespace.php +++ b/src/applications/almanac/storage/AlmanacNamespace.php @@ -191,10 +191,6 @@ final class AlmanacNamespace return new AlmanacNamespaceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacNamespaceTransaction(); } diff --git a/src/applications/almanac/storage/AlmanacNetwork.php b/src/applications/almanac/storage/AlmanacNetwork.php index 3913d2f6e7..78313fad77 100644 --- a/src/applications/almanac/storage/AlmanacNetwork.php +++ b/src/applications/almanac/storage/AlmanacNetwork.php @@ -61,10 +61,6 @@ final class AlmanacNetwork return new AlmanacNetworkEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacNetworkTransaction(); } diff --git a/src/applications/almanac/storage/AlmanacService.php b/src/applications/almanac/storage/AlmanacService.php index 7348abd936..2979b74367 100644 --- a/src/applications/almanac/storage/AlmanacService.php +++ b/src/applications/almanac/storage/AlmanacService.php @@ -226,10 +226,6 @@ final class AlmanacService return new AlmanacServiceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new AlmanacServiceTransaction(); } diff --git a/src/applications/auth/storage/PhabricatorAuthPassword.php b/src/applications/auth/storage/PhabricatorAuthPassword.php index 930cbe61cb..3196b58e60 100644 --- a/src/applications/auth/storage/PhabricatorAuthPassword.php +++ b/src/applications/auth/storage/PhabricatorAuthPassword.php @@ -217,10 +217,6 @@ final class PhabricatorAuthPassword return new PhabricatorAuthPasswordEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorAuthPasswordTransaction(); } diff --git a/src/applications/auth/storage/PhabricatorAuthProviderConfig.php b/src/applications/auth/storage/PhabricatorAuthProviderConfig.php index d4d1f5517c..1de34c4077 100644 --- a/src/applications/auth/storage/PhabricatorAuthProviderConfig.php +++ b/src/applications/auth/storage/PhabricatorAuthProviderConfig.php @@ -91,10 +91,6 @@ final class PhabricatorAuthProviderConfig return new PhabricatorAuthProviderConfigEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorAuthProviderConfigTransaction(); } diff --git a/src/applications/auth/storage/PhabricatorAuthSSHKey.php b/src/applications/auth/storage/PhabricatorAuthSSHKey.php index df4f09c11b..7350af8cfd 100644 --- a/src/applications/auth/storage/PhabricatorAuthSSHKey.php +++ b/src/applications/auth/storage/PhabricatorAuthSSHKey.php @@ -159,10 +159,6 @@ final class PhabricatorAuthSSHKey return new PhabricatorAuthSSHKeyEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorAuthSSHKeyTransaction(); } diff --git a/src/applications/badges/storage/PhabricatorBadgesBadge.php b/src/applications/badges/storage/PhabricatorBadgesBadge.php index c6701a5b62..2fc787d9ee 100644 --- a/src/applications/badges/storage/PhabricatorBadgesBadge.php +++ b/src/applications/badges/storage/PhabricatorBadgesBadge.php @@ -125,10 +125,6 @@ final class PhabricatorBadgesBadge extends PhabricatorBadgesDAO return new PhabricatorBadgesEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorBadgesTransaction(); } diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php index e699a890d4..9526fb1442 100644 --- a/src/applications/base/PhabricatorApplication.php +++ b/src/applications/base/PhabricatorApplication.php @@ -649,10 +649,6 @@ abstract class PhabricatorApplication return new PhabricatorApplicationEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorApplicationApplicationTransaction(); } diff --git a/src/applications/calendar/storage/PhabricatorCalendarEvent.php b/src/applications/calendar/storage/PhabricatorCalendarEvent.php index 51c9a8a973..a8092aaa88 100644 --- a/src/applications/calendar/storage/PhabricatorCalendarEvent.php +++ b/src/applications/calendar/storage/PhabricatorCalendarEvent.php @@ -1311,10 +1311,6 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO return new PhabricatorCalendarEventEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorCalendarEventTransaction(); } diff --git a/src/applications/calendar/storage/PhabricatorCalendarExport.php b/src/applications/calendar/storage/PhabricatorCalendarExport.php index 93daaf6e5d..4ad2b457f3 100644 --- a/src/applications/calendar/storage/PhabricatorCalendarExport.php +++ b/src/applications/calendar/storage/PhabricatorCalendarExport.php @@ -166,10 +166,6 @@ final class PhabricatorCalendarExport extends PhabricatorCalendarDAO return new PhabricatorCalendarExportEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorCalendarExportTransaction(); } diff --git a/src/applications/calendar/storage/PhabricatorCalendarImport.php b/src/applications/calendar/storage/PhabricatorCalendarImport.php index 09e7ee138b..37ddac857c 100644 --- a/src/applications/calendar/storage/PhabricatorCalendarImport.php +++ b/src/applications/calendar/storage/PhabricatorCalendarImport.php @@ -140,10 +140,6 @@ final class PhabricatorCalendarImport return new PhabricatorCalendarImportEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorCalendarImportTransaction(); } diff --git a/src/applications/config/storage/PhabricatorConfigEntry.php b/src/applications/config/storage/PhabricatorConfigEntry.php index 4e28180eed..3462c4e7ba 100644 --- a/src/applications/config/storage/PhabricatorConfigEntry.php +++ b/src/applications/config/storage/PhabricatorConfigEntry.php @@ -61,10 +61,6 @@ final class PhabricatorConfigEntry return new PhabricatorConfigEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorConfigTransaction(); } diff --git a/src/applications/conpherence/storage/ConpherenceThread.php b/src/applications/conpherence/storage/ConpherenceThread.php index 4a99fccdb9..7a5f97ed41 100644 --- a/src/applications/conpherence/storage/ConpherenceThread.php +++ b/src/applications/conpherence/storage/ConpherenceThread.php @@ -311,10 +311,6 @@ final class ConpherenceThread extends ConpherenceDAO return new ConpherenceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new ConpherenceTransaction(); } diff --git a/src/applications/countdown/storage/PhabricatorCountdown.php b/src/applications/countdown/storage/PhabricatorCountdown.php index 0e275604da..1c61ae7ffc 100644 --- a/src/applications/countdown/storage/PhabricatorCountdown.php +++ b/src/applications/countdown/storage/PhabricatorCountdown.php @@ -95,10 +95,6 @@ final class PhabricatorCountdown extends PhabricatorCountdownDAO return new PhabricatorCountdownEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorCountdownTransaction(); } diff --git a/src/applications/dashboard/storage/PhabricatorDashboard.php b/src/applications/dashboard/storage/PhabricatorDashboard.php index 86181dbf9d..53bc2f857d 100644 --- a/src/applications/dashboard/storage/PhabricatorDashboard.php +++ b/src/applications/dashboard/storage/PhabricatorDashboard.php @@ -130,10 +130,6 @@ final class PhabricatorDashboard extends PhabricatorDashboardDAO return new PhabricatorDashboardTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorDashboardTransaction(); } diff --git a/src/applications/dashboard/storage/PhabricatorDashboardPanel.php b/src/applications/dashboard/storage/PhabricatorDashboardPanel.php index ea71e04771..89b577ab87 100644 --- a/src/applications/dashboard/storage/PhabricatorDashboardPanel.php +++ b/src/applications/dashboard/storage/PhabricatorDashboardPanel.php @@ -113,10 +113,6 @@ final class PhabricatorDashboardPanel return new PhabricatorDashboardPanelTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorDashboardPanelTransaction(); } diff --git a/src/applications/differential/storage/DifferentialDiff.php b/src/applications/differential/storage/DifferentialDiff.php index 0b882228c5..e4c33dc766 100644 --- a/src/applications/differential/storage/DifferentialDiff.php +++ b/src/applications/differential/storage/DifferentialDiff.php @@ -699,10 +699,6 @@ final class DifferentialDiff return new DifferentialDiffEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new DifferentialDiffTransaction(); } diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php index ef94da7f67..3397f9cb03 100644 --- a/src/applications/differential/storage/DifferentialRevision.php +++ b/src/applications/differential/storage/DifferentialRevision.php @@ -991,10 +991,6 @@ final class DifferentialRevision extends DifferentialDAO return new DifferentialTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new DifferentialTransaction(); } diff --git a/src/applications/diviner/storage/DivinerLiveBook.php b/src/applications/diviner/storage/DivinerLiveBook.php index d9dfc0107e..480bc50d05 100644 --- a/src/applications/diviner/storage/DivinerLiveBook.php +++ b/src/applications/diviner/storage/DivinerLiveBook.php @@ -143,10 +143,6 @@ final class DivinerLiveBook extends DivinerDAO return new DivinerLiveBookEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new DivinerLiveBookTransaction(); } diff --git a/src/applications/drydock/storage/DrydockBlueprint.php b/src/applications/drydock/storage/DrydockBlueprint.php index 368dbe8f6a..ebe2f9f601 100644 --- a/src/applications/drydock/storage/DrydockBlueprint.php +++ b/src/applications/drydock/storage/DrydockBlueprint.php @@ -295,10 +295,6 @@ final class DrydockBlueprint extends DrydockDAO return new DrydockBlueprintEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new DrydockBlueprintTransaction(); } diff --git a/src/applications/files/storage/PhabricatorFile.php b/src/applications/files/storage/PhabricatorFile.php index 21c9bd2fd3..cc80d272b1 100644 --- a/src/applications/files/storage/PhabricatorFile.php +++ b/src/applications/files/storage/PhabricatorFile.php @@ -1544,10 +1544,6 @@ final class PhabricatorFile extends PhabricatorFileDAO return new PhabricatorFileEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorFileTransaction(); } diff --git a/src/applications/fund/storage/FundBacker.php b/src/applications/fund/storage/FundBacker.php index 67ce3c2d8c..87ab342e2a 100644 --- a/src/applications/fund/storage/FundBacker.php +++ b/src/applications/fund/storage/FundBacker.php @@ -110,10 +110,6 @@ final class FundBacker extends FundDAO return new FundBackerEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new FundBackerTransaction(); } diff --git a/src/applications/fund/storage/FundInitiative.php b/src/applications/fund/storage/FundInitiative.php index 077646fea0..5e4dd48026 100644 --- a/src/applications/fund/storage/FundInitiative.php +++ b/src/applications/fund/storage/FundInitiative.php @@ -160,10 +160,6 @@ final class FundInitiative extends FundDAO return new FundInitiativeEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new FundInitiativeTransaction(); } diff --git a/src/applications/harbormaster/engine/HarbormasterBuildableEngine.php b/src/applications/harbormaster/engine/HarbormasterBuildableEngine.php index 25222975b7..7f743b3adf 100644 --- a/src/applications/harbormaster/engine/HarbormasterBuildableEngine.php +++ b/src/applications/harbormaster/engine/HarbormasterBuildableEngine.php @@ -96,9 +96,7 @@ abstract class HarbormasterBuildableEngine $publishable = $this->getPublishableObject(); $editor = $this->newEditor(); - $editor->applyTransactions( - $publishable->getApplicationTransactionObject(), - $xactions); + $editor->applyTransactions($publishable, $xactions); } public function getAuthorIdentity() { diff --git a/src/applications/harbormaster/storage/HarbormasterBuildable.php b/src/applications/harbormaster/storage/HarbormasterBuildable.php index 0e2e93a0c9..aabfd49eb9 100644 --- a/src/applications/harbormaster/storage/HarbormasterBuildable.php +++ b/src/applications/harbormaster/storage/HarbormasterBuildable.php @@ -283,10 +283,6 @@ final class HarbormasterBuildable return new HarbormasterBuildableTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HarbormasterBuildableTransaction(); } diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuild.php b/src/applications/harbormaster/storage/build/HarbormasterBuild.php index 04ba35ee1e..602e388477 100644 --- a/src/applications/harbormaster/storage/build/HarbormasterBuild.php +++ b/src/applications/harbormaster/storage/build/HarbormasterBuild.php @@ -393,10 +393,6 @@ final class HarbormasterBuild extends HarbormasterDAO return new HarbormasterBuildTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HarbormasterBuildTransaction(); } diff --git a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php index a41dc89790..2e379aab23 100644 --- a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php +++ b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php @@ -136,10 +136,6 @@ final class HarbormasterBuildPlan extends HarbormasterDAO return new HarbormasterBuildPlanEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HarbormasterBuildPlanTransaction(); } diff --git a/src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php b/src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php index cee9a3f9c3..dd0ebdc507 100644 --- a/src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php +++ b/src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php @@ -121,10 +121,6 @@ final class HarbormasterBuildStep extends HarbormasterDAO return new HarbormasterBuildStepEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HarbormasterBuildStepTransaction(); } diff --git a/src/applications/herald/storage/HeraldRule.php b/src/applications/herald/storage/HeraldRule.php index 6b078336aa..1b005898cb 100644 --- a/src/applications/herald/storage/HeraldRule.php +++ b/src/applications/herald/storage/HeraldRule.php @@ -318,10 +318,6 @@ final class HeraldRule extends HeraldDAO return new HeraldRuleEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HeraldRuleTransaction(); } diff --git a/src/applications/herald/storage/HeraldWebhook.php b/src/applications/herald/storage/HeraldWebhook.php index aa992ec203..0101dbef52 100644 --- a/src/applications/herald/storage/HeraldWebhook.php +++ b/src/applications/herald/storage/HeraldWebhook.php @@ -200,10 +200,6 @@ final class HeraldWebhook return new HeraldWebhookEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new HeraldWebhookTransaction(); } diff --git a/src/applications/legalpad/storage/LegalpadDocument.php b/src/applications/legalpad/storage/LegalpadDocument.php index 428a35b56c..efcd6b5f15 100644 --- a/src/applications/legalpad/storage/LegalpadDocument.php +++ b/src/applications/legalpad/storage/LegalpadDocument.php @@ -209,10 +209,6 @@ final class LegalpadDocument extends LegalpadDAO return new LegalpadDocumentEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new LegalpadTransaction(); } diff --git a/src/applications/macro/storage/PhabricatorFileImageMacro.php b/src/applications/macro/storage/PhabricatorFileImageMacro.php index 8c0631cf84..656a4c9c57 100644 --- a/src/applications/macro/storage/PhabricatorFileImageMacro.php +++ b/src/applications/macro/storage/PhabricatorFileImageMacro.php @@ -98,10 +98,6 @@ final class PhabricatorFileImageMacro extends PhabricatorFileDAO return new PhabricatorMacroEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorMacroTransaction(); } diff --git a/src/applications/maniphest/storage/ManiphestTask.php b/src/applications/maniphest/storage/ManiphestTask.php index 7b9b7d2b91..1372e2cb88 100644 --- a/src/applications/maniphest/storage/ManiphestTask.php +++ b/src/applications/maniphest/storage/ManiphestTask.php @@ -452,10 +452,6 @@ final class ManiphestTask extends ManiphestDAO return new ManiphestTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new ManiphestTransaction(); } diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php b/src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php index 623fd88e91..39eb4001cd 100644 --- a/src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php +++ b/src/applications/metamta/storage/PhabricatorMetaMTAApplicationEmail.php @@ -123,10 +123,6 @@ final class PhabricatorMetaMTAApplicationEmail return new PhabricatorMetaMTAApplicationEmailEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorMetaMTAApplicationEmailTransaction(); } diff --git a/src/applications/nuance/storage/NuanceItem.php b/src/applications/nuance/storage/NuanceItem.php index 4f9ab750c1..f182e17580 100644 --- a/src/applications/nuance/storage/NuanceItem.php +++ b/src/applications/nuance/storage/NuanceItem.php @@ -193,10 +193,6 @@ final class NuanceItem return new NuanceItemEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new NuanceItemTransaction(); } diff --git a/src/applications/nuance/storage/NuanceQueue.php b/src/applications/nuance/storage/NuanceQueue.php index 7cbb1e761c..a19f1693b3 100644 --- a/src/applications/nuance/storage/NuanceQueue.php +++ b/src/applications/nuance/storage/NuanceQueue.php @@ -79,10 +79,6 @@ final class NuanceQueue return new NuanceQueueEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new NuanceQueueTransaction(); } diff --git a/src/applications/nuance/storage/NuanceSource.php b/src/applications/nuance/storage/NuanceSource.php index 0f0dd4d7de..5e06a5dc0a 100644 --- a/src/applications/nuance/storage/NuanceSource.php +++ b/src/applications/nuance/storage/NuanceSource.php @@ -99,10 +99,6 @@ final class NuanceSource extends NuanceDAO return new NuanceSourceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new NuanceSourceTransaction(); } diff --git a/src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php b/src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php index 1ebecbc369..a951bf5781 100644 --- a/src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php +++ b/src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php @@ -91,10 +91,6 @@ final class PhabricatorOAuthServerClient return new PhabricatorOAuthServerEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorOAuthServerTransaction(); } diff --git a/src/applications/owners/storage/PhabricatorOwnersPackage.php b/src/applications/owners/storage/PhabricatorOwnersPackage.php index 17954ea80a..564fc8a28b 100644 --- a/src/applications/owners/storage/PhabricatorOwnersPackage.php +++ b/src/applications/owners/storage/PhabricatorOwnersPackage.php @@ -607,10 +607,6 @@ final class PhabricatorOwnersPackage return new PhabricatorOwnersPackageTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorOwnersPackageTransaction(); } diff --git a/src/applications/packages/storage/PhabricatorPackagesPackage.php b/src/applications/packages/storage/PhabricatorPackagesPackage.php index 822988e8fb..15748329e7 100644 --- a/src/applications/packages/storage/PhabricatorPackagesPackage.php +++ b/src/applications/packages/storage/PhabricatorPackagesPackage.php @@ -189,10 +189,6 @@ final class PhabricatorPackagesPackage return new PhabricatorPackagesPackageEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorPackagesPackageTransaction(); } diff --git a/src/applications/packages/storage/PhabricatorPackagesPublisher.php b/src/applications/packages/storage/PhabricatorPackagesPublisher.php index b7610499d4..21b586dc1f 100644 --- a/src/applications/packages/storage/PhabricatorPackagesPublisher.php +++ b/src/applications/packages/storage/PhabricatorPackagesPublisher.php @@ -165,10 +165,6 @@ final class PhabricatorPackagesPublisher return new PhabricatorPackagesPublisherEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorPackagesPublisherTransaction(); } diff --git a/src/applications/packages/storage/PhabricatorPackagesVersion.php b/src/applications/packages/storage/PhabricatorPackagesVersion.php index e1abf043a1..cd5e2648f8 100644 --- a/src/applications/packages/storage/PhabricatorPackagesVersion.php +++ b/src/applications/packages/storage/PhabricatorPackagesVersion.php @@ -156,10 +156,6 @@ final class PhabricatorPackagesVersion return new PhabricatorPackagesVersionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorPackagesVersionTransaction(); } diff --git a/src/applications/passphrase/storage/PassphraseCredential.php b/src/applications/passphrase/storage/PassphraseCredential.php index 6cb7cbf24e..b10d392d36 100644 --- a/src/applications/passphrase/storage/PassphraseCredential.php +++ b/src/applications/passphrase/storage/PassphraseCredential.php @@ -117,10 +117,6 @@ final class PassphraseCredential extends PassphraseDAO return new PassphraseCredentialTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PassphraseCredentialTransaction(); } diff --git a/src/applications/paste/storage/PhabricatorPaste.php b/src/applications/paste/storage/PhabricatorPaste.php index ad3965ce46..79f1a953f6 100644 --- a/src/applications/paste/storage/PhabricatorPaste.php +++ b/src/applications/paste/storage/PhabricatorPaste.php @@ -219,10 +219,6 @@ final class PhabricatorPaste extends PhabricatorPasteDAO return new PhabricatorPasteEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorPasteTransaction(); } diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php index 9b6f6cdbe4..8b1c7cba5c 100644 --- a/src/applications/people/storage/PhabricatorUser.php +++ b/src/applications/people/storage/PhabricatorUser.php @@ -1371,10 +1371,6 @@ final class PhabricatorUser return new PhabricatorUserTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorUserTransaction(); } diff --git a/src/applications/phame/storage/PhameBlog.php b/src/applications/phame/storage/PhameBlog.php index fde39da0fc..71a5186225 100644 --- a/src/applications/phame/storage/PhameBlog.php +++ b/src/applications/phame/storage/PhameBlog.php @@ -331,10 +331,6 @@ final class PhameBlog extends PhameDAO return new PhameBlogEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhameBlogTransaction(); } diff --git a/src/applications/phame/storage/PhamePost.php b/src/applications/phame/storage/PhamePost.php index c95d48054b..300579b086 100644 --- a/src/applications/phame/storage/PhamePost.php +++ b/src/applications/phame/storage/PhamePost.php @@ -279,10 +279,6 @@ final class PhamePost extends PhameDAO return new PhamePostEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhamePostTransaction(); } diff --git a/src/applications/phlux/storage/PhluxVariable.php b/src/applications/phlux/storage/PhluxVariable.php index d8c2d5315e..fb0d5c2f80 100644 --- a/src/applications/phlux/storage/PhluxVariable.php +++ b/src/applications/phlux/storage/PhluxVariable.php @@ -41,10 +41,6 @@ final class PhluxVariable extends PhluxDAO return new PhluxVariableEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhluxTransaction(); } diff --git a/src/applications/pholio/storage/PholioMock.php b/src/applications/pholio/storage/PholioMock.php index 51bdd1a196..a7e9a9b05d 100644 --- a/src/applications/pholio/storage/PholioMock.php +++ b/src/applications/pholio/storage/PholioMock.php @@ -221,10 +221,6 @@ final class PholioMock extends PholioDAO return new PholioMockEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PholioTransaction(); } diff --git a/src/applications/phortune/storage/PhortuneAccount.php b/src/applications/phortune/storage/PhortuneAccount.php index 8402ffa6d1..b0b57645c3 100644 --- a/src/applications/phortune/storage/PhortuneAccount.php +++ b/src/applications/phortune/storage/PhortuneAccount.php @@ -105,10 +105,6 @@ final class PhortuneAccount extends PhortuneDAO return new PhortuneAccountEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhortuneAccountTransaction(); } diff --git a/src/applications/phortune/storage/PhortuneCart.php b/src/applications/phortune/storage/PhortuneCart.php index 81f7099d0f..2b121a3b0c 100644 --- a/src/applications/phortune/storage/PhortuneCart.php +++ b/src/applications/phortune/storage/PhortuneCart.php @@ -636,10 +636,6 @@ final class PhortuneCart extends PhortuneDAO return new PhortuneCartEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhortuneCartTransaction(); } diff --git a/src/applications/phortune/storage/PhortuneMerchant.php b/src/applications/phortune/storage/PhortuneMerchant.php index a4fff91c5e..4916cfede7 100644 --- a/src/applications/phortune/storage/PhortuneMerchant.php +++ b/src/applications/phortune/storage/PhortuneMerchant.php @@ -78,10 +78,6 @@ final class PhortuneMerchant extends PhortuneDAO return new PhortuneMerchantEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhortuneMerchantTransaction(); } diff --git a/src/applications/phortune/storage/PhortunePaymentProviderConfig.php b/src/applications/phortune/storage/PhortunePaymentProviderConfig.php index 65d5b3e65c..1e151b3fbb 100644 --- a/src/applications/phortune/storage/PhortunePaymentProviderConfig.php +++ b/src/applications/phortune/storage/PhortunePaymentProviderConfig.php @@ -106,10 +106,6 @@ final class PhortunePaymentProviderConfig extends PhortuneDAO return new PhortunePaymentProviderConfigEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhortunePaymentProviderConfigTransaction(); } diff --git a/src/applications/phriction/storage/PhrictionDocument.php b/src/applications/phriction/storage/PhrictionDocument.php index 24f216fe26..9f8a4a475b 100644 --- a/src/applications/phriction/storage/PhrictionDocument.php +++ b/src/applications/phriction/storage/PhrictionDocument.php @@ -223,10 +223,6 @@ final class PhrictionDocument extends PhrictionDAO return new PhrictionTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhrictionTransaction(); } diff --git a/src/applications/phurl/storage/PhabricatorPhurlURL.php b/src/applications/phurl/storage/PhabricatorPhurlURL.php index 76a4fd045a..4f3ee36dea 100644 --- a/src/applications/phurl/storage/PhabricatorPhurlURL.php +++ b/src/applications/phurl/storage/PhabricatorPhurlURL.php @@ -157,10 +157,6 @@ final class PhabricatorPhurlURL extends PhabricatorPhurlDAO return new PhabricatorPhurlURLEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorPhurlURLTransaction(); } diff --git a/src/applications/ponder/storage/PonderAnswer.php b/src/applications/ponder/storage/PonderAnswer.php index 0dcf44d617..9179e22a44 100644 --- a/src/applications/ponder/storage/PonderAnswer.php +++ b/src/applications/ponder/storage/PonderAnswer.php @@ -117,10 +117,6 @@ final class PonderAnswer extends PonderDAO return new PonderAnswerEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PonderAnswerTransaction(); } diff --git a/src/applications/ponder/storage/PonderQuestion.php b/src/applications/ponder/storage/PonderQuestion.php index 2ae6c76d68..40ec9fbee8 100644 --- a/src/applications/ponder/storage/PonderQuestion.php +++ b/src/applications/ponder/storage/PonderQuestion.php @@ -145,10 +145,6 @@ final class PonderQuestion extends PonderDAO return new PonderQuestionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PonderQuestionTransaction(); } diff --git a/src/applications/project/storage/PhabricatorProject.php b/src/applications/project/storage/PhabricatorProject.php index adbfb0dc36..4dae13f3c6 100644 --- a/src/applications/project/storage/PhabricatorProject.php +++ b/src/applications/project/storage/PhabricatorProject.php @@ -695,10 +695,6 @@ final class PhabricatorProject extends PhabricatorProjectDAO return new PhabricatorProjectTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorProjectTransaction(); } diff --git a/src/applications/project/storage/PhabricatorProjectColumn.php b/src/applications/project/storage/PhabricatorProjectColumn.php index b4c5df885e..756c356ee1 100644 --- a/src/applications/project/storage/PhabricatorProjectColumn.php +++ b/src/applications/project/storage/PhabricatorProjectColumn.php @@ -234,10 +234,6 @@ final class PhabricatorProjectColumn return new PhabricatorProjectColumnTransactionEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorProjectColumnTransaction(); } diff --git a/src/applications/releeph/storage/ReleephBranch.php b/src/applications/releeph/storage/ReleephBranch.php index 5e23499a9d..28323a9981 100644 --- a/src/applications/releeph/storage/ReleephBranch.php +++ b/src/applications/releeph/storage/ReleephBranch.php @@ -158,10 +158,6 @@ final class ReleephBranch extends ReleephDAO return new ReleephBranchEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new ReleephBranchTransaction(); } diff --git a/src/applications/releeph/storage/ReleephProject.php b/src/applications/releeph/storage/ReleephProject.php index 318d687efd..db47ac5d39 100644 --- a/src/applications/releeph/storage/ReleephProject.php +++ b/src/applications/releeph/storage/ReleephProject.php @@ -119,10 +119,6 @@ final class ReleephProject extends ReleephDAO return new ReleephProductEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new ReleephProductTransaction(); } diff --git a/src/applications/releeph/storage/ReleephRequest.php b/src/applications/releeph/storage/ReleephRequest.php index 23956e4a3c..c21f9b28c8 100644 --- a/src/applications/releeph/storage/ReleephRequest.php +++ b/src/applications/releeph/storage/ReleephRequest.php @@ -299,10 +299,6 @@ final class ReleephRequest extends ReleephDAO return new ReleephRequestTransactionalEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new ReleephRequestTransaction(); } diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php index 6967085644..e1febe7ac8 100644 --- a/src/applications/repository/storage/PhabricatorRepository.php +++ b/src/applications/repository/storage/PhabricatorRepository.php @@ -2613,10 +2613,6 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO return new PhabricatorRepositoryEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorRepositoryTransaction(); } diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php index ddc4dbbf9f..fecb1762bd 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php +++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php @@ -731,10 +731,6 @@ final class PhabricatorRepositoryCommit return new PhabricatorAuditEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorAuditTransaction(); } diff --git a/src/applications/repository/storage/PhabricatorRepositoryIdentity.php b/src/applications/repository/storage/PhabricatorRepositoryIdentity.php index d361ccda40..76c6aed9e0 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryIdentity.php +++ b/src/applications/repository/storage/PhabricatorRepositoryIdentity.php @@ -134,10 +134,6 @@ final class PhabricatorRepositoryIdentity return new DiffusionRepositoryIdentityEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorRepositoryIdentityTransaction(); } diff --git a/src/applications/repository/storage/PhabricatorRepositoryURI.php b/src/applications/repository/storage/PhabricatorRepositoryURI.php index cc0f28b828..8b1de62dd6 100644 --- a/src/applications/repository/storage/PhabricatorRepositoryURI.php +++ b/src/applications/repository/storage/PhabricatorRepositoryURI.php @@ -605,10 +605,6 @@ final class PhabricatorRepositoryURI return new DiffusionURIEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorRepositoryURITransaction(); } diff --git a/src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php b/src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php index ba6a5b2ef8..8520cac1bd 100644 --- a/src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php +++ b/src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php @@ -265,10 +265,6 @@ final class PhabricatorProfileMenuItemConfiguration return new PhabricatorProfileMenuEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorProfileMenuItemConfigurationTransaction(); } diff --git a/src/applications/settings/storage/PhabricatorUserPreferences.php b/src/applications/settings/storage/PhabricatorUserPreferences.php index 9280608457..0af6b4553c 100644 --- a/src/applications/settings/storage/PhabricatorUserPreferences.php +++ b/src/applications/settings/storage/PhabricatorUserPreferences.php @@ -245,10 +245,6 @@ final class PhabricatorUserPreferences return new PhabricatorUserPreferencesEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorUserPreferencesTransaction(); } diff --git a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php index fcf0009448..b8355c0586 100644 --- a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php +++ b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php @@ -131,10 +131,6 @@ final class PhabricatorSlowvotePoll extends PhabricatorSlowvoteDAO return new PhabricatorSlowvoteEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorSlowvoteTransaction(); } diff --git a/src/applications/spaces/storage/PhabricatorSpacesNamespace.php b/src/applications/spaces/storage/PhabricatorSpacesNamespace.php index 6b51d9c999..e8b2afb435 100644 --- a/src/applications/spaces/storage/PhabricatorSpacesNamespace.php +++ b/src/applications/spaces/storage/PhabricatorSpacesNamespace.php @@ -91,10 +91,6 @@ final class PhabricatorSpacesNamespace return new PhabricatorSpacesNamespaceEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorSpacesNamespaceTransaction(); } diff --git a/src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php b/src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php index 817e92ce39..13a0e14c23 100644 --- a/src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php +++ b/src/applications/subscriptions/controller/PhabricatorSubscriptionsEditController.php @@ -77,9 +77,7 @@ final class PhabricatorSubscriptionsEditController ->setContinueOnMissingFields(true) ->setContentSourceFromRequest($request); - $editor->applyTransactions( - $object->getApplicationTransactionObject(), - array($xaction)); + $editor->applyTransactions($object, array($xaction)); } else { // TODO: Eventually, get rid of this once everything implements diff --git a/src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php b/src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php index e29d5e3802..929a4985dd 100644 --- a/src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php +++ b/src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php @@ -55,9 +55,7 @@ final class PhabricatorSubscriptionsMuteController ->setContinueOnMissingFields(true) ->setContentSourceFromRequest($request); - $editor->applyTransactions( - $object->getApplicationTransactionObject(), - array($xaction)); + $editor->applyTransactions($object, array($xaction)); return id(new AphrontReloadResponse())->setURI($object_uri); } diff --git a/src/applications/tokens/editor/PhabricatorTokenGivenEditor.php b/src/applications/tokens/editor/PhabricatorTokenGivenEditor.php index ea4e8367c0..0d2f143635 100644 --- a/src/applications/tokens/editor/PhabricatorTokenGivenEditor.php +++ b/src/applications/tokens/editor/PhabricatorTokenGivenEditor.php @@ -166,9 +166,7 @@ final class PhabricatorTokenGivenEditor ->setContinueOnNoEffect(true) ->setContinueOnMissingFields(true); - $editor->applyTransactions( - $object->getApplicationTransactionObject(), - $xactions); + $editor->applyTransactions($object, $xactions); } } diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php index 738fcf098b..697c4600a5 100644 --- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php +++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php @@ -3766,7 +3766,6 @@ abstract class PhabricatorApplicationTransactionEditor $editor = $node->getApplicationTransactionEditor(); $template = $node->getApplicationTransactionTemplate(); - $target = $node->getApplicationTransactionObject(); if (isset($add[$node->getPHID()])) { $edge_edit_type = '+'; @@ -3792,7 +3791,7 @@ abstract class PhabricatorApplicationTransactionEditor ->setActingAsPHID($this->getActingAsPHID()) ->setContentSource($this->getContentSource()); - $editor->applyTransactions($target, array($template)); + $editor->applyTransactions($node, array($template)); } } diff --git a/src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php b/src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php index 1c6b4a0049..205253ba22 100644 --- a/src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php +++ b/src/applications/transactions/interface/PhabricatorApplicationTransactionInterface.php @@ -17,17 +17,6 @@ interface PhabricatorApplicationTransactionInterface { public function getApplicationTransactionEditor(); - /** - * Return the object to apply transactions to. Normally this is the current - * object (that is, `$this`), but in some cases transactions may apply to - * a different object: for example, @{class:DifferentialDiff} applies - * transactions to the associated @{class:DifferentialRevision}. - * - * @return PhabricatorLiskDAO Object to apply transactions to. - */ - public function getApplicationTransactionObject(); - - /** * Return a template transaction for this object. * @@ -47,10 +36,6 @@ interface PhabricatorApplicationTransactionInterface { return new <<>>Editor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new <<>>Transaction(); } diff --git a/src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php b/src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php index 5457708953..9a369717f0 100644 --- a/src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php +++ b/src/applications/transactions/replyhandler/PhabricatorApplicationTransactionReplyHandler.php @@ -107,11 +107,9 @@ abstract class PhabricatorApplicationTransactionReplyHandler ->attachComment($comment); } - $target = $object->getApplicationTransactionObject(); - $this->newEditor($mail) ->setContinueOnNoEffect(true) - ->applyTransactions($target, $xactions); + ->applyTransactions($object, $xactions); } private function processMailCommands( diff --git a/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php b/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php index 707dbe9714..6c9f3a50a6 100644 --- a/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php +++ b/src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php @@ -339,10 +339,6 @@ final class PhabricatorEditEngineConfiguration return new PhabricatorEditEngineConfigurationEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorEditEngineConfigurationTransaction(); } diff --git a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php index d6e8437091..68263fccb7 100644 --- a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php +++ b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php @@ -233,10 +233,6 @@ final class PhabricatorWorkerBulkJob return new PhabricatorWorkerBulkJobEditor(); } - public function getApplicationTransactionObject() { - return $this; - } - public function getApplicationTransactionTemplate() { return new PhabricatorWorkerBulkJobTransaction(); }