From 121e68e3adae4cd21731b79c07ca89676def7e19 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 15 Mar 2016 08:16:18 -0700 Subject: [PATCH] Fix an issue with rendering unit messages for diffs with no buildable Summary: Fixes T10591. This was accidentally reverted in 148a50e48be146b88036032d1cad772d2627da28, probably when resolvign a merge/rebase. Test Plan: Will push to production. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10591 Differential Revision: https://secure.phabricator.com/D15474 --- .../controller/DifferentialRevisionViewController.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php index c59ee04047..75602af0a6 100644 --- a/src/applications/differential/controller/DifferentialRevisionViewController.php +++ b/src/applications/differential/controller/DifferentialRevisionViewController.php @@ -1131,6 +1131,10 @@ final class DifferentialRevisionViewController extends DifferentialController { DifferentialRevision $revision) { $viewer = $this->getViewer(); + if (!$diff->getBuildable()) { + return null; + } + if (!$diff->getUnitMessages()) { return null; }