Avoid double escaping in Remarkup

Summary:
These all work with plain text.

Fixes T2574.

Test Plan:
  lang=remarkup
  > [[ a | <a> ]]

  - [[ /a | <a> ]]

  //a**b**c//

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2574

Differential Revision: https://secure.phabricator.com/D5060

src/applications/diviner/markup/DivinerRemarkupRuleSymbol.php

@@ -19,7 +19,7 @@ final class DivinerRemarkupRuleSymbol extends PhutilRemarkupRule {
     //   @{name | title}
     //   @{type @ book : name @ context | title}
 
-    return $this->replaceHTML(
+    return preg_replace_callback(
       '/(?:^|\B)@{'.
         '(?:(?P<type>[^:]+?):)?'.
         '(?P<name>[^}|]+?)'.

src/infrastructure/markup/rule/PhabricatorRemarkupRuleCountdown.php

@@ -8,7 +8,7 @@ final class PhabricatorRemarkupRuleCountdown extends PhutilRemarkupRule {
   const KEY_RULE_COUNTDOWN = 'rule.countdown';
 
   public function apply($text) {
-    return $this->replaceHTML(
+    return preg_replace_callback(
       "@\B{C(\d+)}\B@",
       array($this, 'markupCountdown'),
       $text);

src/infrastructure/markup/rule/PhabricatorRemarkupRuleEmbedFile.php

@@ -10,7 +10,7 @@ final class PhabricatorRemarkupRuleEmbedFile
   const KEY_EMBED_FILE_PHIDS = 'phabricator.embedded-file-phids';
 
   public function apply($text) {
-    return $this->replaceHTML(
+    return preg_replace_callback(
       "@{F(\d+)([^}]+?)?}@",
       array($this, 'markupEmbedFile'),
       $text);

src/infrastructure/markup/rule/PhabricatorRemarkupRuleImageMacro.php

@@ -9,7 +9,7 @@ final class PhabricatorRemarkupRuleImageMacro
   private $images;
 
   public function apply($text) {
-    return $this->replaceHTML(
+    return preg_replace_callback(
       '@^([a-zA-Z0-9:_\-]+)$@m',
       array($this, 'markupImageMacro'),
       $text);

src/infrastructure/markup/rule/PhabricatorRemarkupRuleMeme.php

@@ -9,7 +9,7 @@ final class PhabricatorRemarkupRuleMeme
   private $images;
 
   public function apply($text) {
-    return $this->replaceHTML(
+    return preg_replace_callback(
       '@{meme,([^}]+)}$@m',
       array($this, 'markupMeme'),
       $text);

src/infrastructure/markup/rule/PhabricatorRemarkupRuleMention.php

@@ -21,7 +21,7 @@ final class PhabricatorRemarkupRuleMention
   const REGEX = '/(?<!\w)@([a-zA-Z0-9._-]*[a-zA-Z0-9_-])/';
 
   public function apply($text) {
-    return $this->replaceHTML(
+    return preg_replace_callback(
       self::REGEX,
       array($this, 'markupMention'),
       $text);

src/infrastructure/markup/rule/PhabricatorRemarkupRuleObjectHandle.php

@@ -13,7 +13,7 @@ abstract class PhabricatorRemarkupRuleObjectHandle
 
   public function apply($text) {
     $prefix = $this->getObjectNamePrefix();
-    return $this->replaceHTML(
+    return preg_replace_callback(
       "@\B{{$prefix}(\d+)}\B@",
       array($this, 'markupObjectHandle'),
       $text);

src/infrastructure/markup/rule/PhabricatorRemarkupRuleObjectName.php

@@ -15,7 +15,7 @@ abstract class PhabricatorRemarkupRuleObjectName
   public function apply($text) {
     $prefix = $this->getObjectNamePrefix();
     $id = $this->getObjectIDPattern();
-    return $this->replaceHTML(
+    return preg_replace_callback(
       "@\b({$prefix})({$id})(?:#([-\w\d]+))?\b@",
       array($this, 'markupObjectNameLink'),
       $text);

src/infrastructure/markup/rule/PhabricatorRemarkupRulePhriction.php

@@ -7,7 +7,7 @@ final class PhabricatorRemarkupRulePhriction
   extends PhutilRemarkupRule {
 
   public function apply($text) {
-    return $this->replaceHTML(
+    return preg_replace_callback(
       '@\B\\[\\[([^|\\]]+)(?:\\|([^\\]]+))?\\]\\]\B@U',
       array($this, 'markupDocumentLink'),
       $text);