From 125e5b16db3a3d0eb2d2f30f1d6cbfe7f15ac436 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sat, 17 Dec 2011 16:10:44 -0800
Subject: [PATCH] Remove "PHID Manager" Tool list interface

Summary: This was well-intentioned but has not actually proven to be useful.

Test Plan:
  - No list tab shows up anymore.
  - Looked up a PHID.

Reviewers: btrahan, jungejason, Girish

Reviewed By: Girish

CC: aran, jungejason, edward, emiraga, Girish, nh, tuomaspelkonen, epriestley

Maniphest Tasks: T631

Differential Revision: 1234
---
 ...AphrontDefaultApplicationConfiguration.php |  1 -
 .../base/PhabricatorPHIDController.php        | 12 ----
 .../list/PhabricatorPHIDListController.php    | 60 -------------------
 .../phid/controller/list/__init__.php         | 18 ------
 .../PhabricatorPHIDLookupController.php       |  1 -
 5 files changed, 92 deletions(-)
 delete mode 100644 src/applications/phid/controller/list/PhabricatorPHIDListController.php
 delete mode 100644 src/applications/phid/controller/list/__init__.php

diff --git a/src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php b/src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php
index 17ece2998f..8c331d235d 100644
--- a/src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php
+++ b/src/aphront/default/configuration/AphrontDefaultApplicationConfiguration.php
@@ -70,7 +70,6 @@ class AphrontDefaultApplicationConfiguration
       ),
       '/phid/' => array(
         '$' => 'PhabricatorPHIDLookupController',
-        'list/$' => 'PhabricatorPHIDListController',
       ),
       '/people/' => array(
         '$' => 'PhabricatorPeopleListController',
diff --git a/src/applications/phid/controller/base/PhabricatorPHIDController.php b/src/applications/phid/controller/base/PhabricatorPHIDController.php
index 357164d4f0..f771b278f7 100644
--- a/src/applications/phid/controller/base/PhabricatorPHIDController.php
+++ b/src/applications/phid/controller/base/PhabricatorPHIDController.php
@@ -24,18 +24,6 @@ abstract class PhabricatorPHIDController extends PhabricatorController {
     $page->setApplicationName('PHID');
     $page->setBaseURI('/phid/');
     $page->setTitle(idx($data, 'title'));
-    $page->setTabs(
-      array(
-        'lookup' => array(
-          'href' => '/phid/',
-          'name' => 'PHID Lookup',
-        ),
-        'phids' => array(
-          'href' => '/phid/list/',
-          'name' => 'PHID List',
-        ),
-      ),
-      idx($data, 'tab'));
     $page->setGlyph('#');
     $page->appendChild($view);
 
diff --git a/src/applications/phid/controller/list/PhabricatorPHIDListController.php b/src/applications/phid/controller/list/PhabricatorPHIDListController.php
deleted file mode 100644
index 8e1a0dc569..0000000000
--- a/src/applications/phid/controller/list/PhabricatorPHIDListController.php
+++ /dev/null
@@ -1,60 +0,0 @@
-<?php
-
-/*
- * Copyright 2011 Facebook, Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-class PhabricatorPHIDListController
-  extends PhabricatorPHIDController {
-
-  public function processRequest() {
-    $items = id(new PhabricatorPHID())->loadAllWhere(
-      '1 = 1 ORDER BY id DESC limit 100');
-
-    $rows = array();
-    foreach ($items as $item) {
-      $rows[] = array(
-        phutil_escape_html($item->getPHID()),
-        phutil_escape_html($item->getPHIDType()),
-        phutil_escape_html($item->getOwnerPHID()),
-        phutil_escape_html($item->getParentPHID()),
-      );
-    }
-
-    $table = new AphrontTableView($rows);
-    $table->setHeaders(
-      array(
-        'PHID',
-        'Type',
-        'Owner PHID',
-        'Parent PHID',
-      ));
-
-    $panel = new AphrontPanelView();
-    $panel->appendChild($table);
-    $panel->setHeader('PHIDs');
-    $panel->setCreateButton('Allocate New PHID', '/phid/new/');
-
-    return $this->buildStandardPageResponse(
-      array(
-        $panel,
-      ),
-      array(
-        'title' => 'PHIDs',
-        'tab'   => 'phids',
-      ));
-  }
-
-}
diff --git a/src/applications/phid/controller/list/__init__.php b/src/applications/phid/controller/list/__init__.php
deleted file mode 100644
index 913d4fe3f1..0000000000
--- a/src/applications/phid/controller/list/__init__.php
+++ /dev/null
@@ -1,18 +0,0 @@
-<?php
-/**
- * This file is automatically generated. Lint this module to rebuild it.
- * @generated
- */
-
-
-
-phutil_require_module('phabricator', 'applications/phid/controller/base');
-phutil_require_module('phabricator', 'applications/phid/storage/phid');
-phutil_require_module('phabricator', 'view/control/table');
-phutil_require_module('phabricator', 'view/layout/panel');
-
-phutil_require_module('phutil', 'markup');
-phutil_require_module('phutil', 'utils');
-
-
-phutil_require_source('PhabricatorPHIDListController.php');
diff --git a/src/applications/phid/controller/lookup/PhabricatorPHIDLookupController.php b/src/applications/phid/controller/lookup/PhabricatorPHIDLookupController.php
index cb8f4cbbc0..e95dd94b05 100644
--- a/src/applications/phid/controller/lookup/PhabricatorPHIDLookupController.php
+++ b/src/applications/phid/controller/lookup/PhabricatorPHIDLookupController.php
@@ -105,7 +105,6 @@ class PhabricatorPHIDLookupController
       ),
       array(
         'title' => 'PHID Lookup',
-        'tab'   => 'lookup',
       ));
   }