From 127c8b806fc8632946aee3325b88112caf07ddb2 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Fri, 31 May 2013 11:30:55 -0700 Subject: [PATCH] Set untitled Conpherences to '[No Title]' so users change them Summary: This mainly affects crumbs, makes it more clear that the Conpherence doesn't have a set title. Test Plan: Clear a title, see [No Title] Reviewers: epriestley, btrahan Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D6099 --- .../conpherence/controller/ConpherenceController.php | 2 +- .../conpherence/controller/ConpherenceViewController.php | 2 +- src/applications/conpherence/storage/ConpherenceThread.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/applications/conpherence/controller/ConpherenceController.php b/src/applications/conpherence/controller/ConpherenceController.php index b2e0f49b3e..f24629b3e8 100644 --- a/src/applications/conpherence/controller/ConpherenceController.php +++ b/src/applications/conpherence/controller/ConpherenceController.php @@ -58,7 +58,7 @@ abstract class ConpherenceController extends PhabricatorController { if ($conpherence->getTitle()) { $title = $conpherence->getTitle(); } else { - $title = pht('Conpherence'); + $title = pht('[No Title]'); } $crumbs->addCrumb( id(new PhabricatorCrumbView()) diff --git a/src/applications/conpherence/controller/ConpherenceViewController.php b/src/applications/conpherence/controller/ConpherenceViewController.php index 3d5d9b2f50..9720b44018 100644 --- a/src/applications/conpherence/controller/ConpherenceViewController.php +++ b/src/applications/conpherence/controller/ConpherenceViewController.php @@ -93,7 +93,7 @@ final class ConpherenceViewController extends $title = $conpherence->getTitle(); if (!$title) { - $title = pht('Conpherence'); + $title = pht('[No Title]'); } return $this->buildApplicationPage( $layout, diff --git a/src/applications/conpherence/storage/ConpherenceThread.php b/src/applications/conpherence/storage/ConpherenceThread.php index acae732b71..2d1f852cc2 100644 --- a/src/applications/conpherence/storage/ConpherenceThread.php +++ b/src/applications/conpherence/storage/ConpherenceThread.php @@ -160,7 +160,7 @@ final class ConpherenceThread extends ConpherenceDAO $title = $js_title = $this->getTitle(); if (!$title) { $title = $lucky_handle->getName(); - $js_title = pht('Conpherence'); + $js_title = pht('[No Title]'); } $img_src = $lucky_handle->getImageURI();