From 12f2ffd46a6597156c617f823c297fa1d2b375d0 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@chadsdomain.com>
Date: Tue, 10 Jun 2014 09:16:29 -0700
Subject: [PATCH] Add white as ActionHeader color, use on Dashboards

Summary: Trying to lessen the visual footprint of a heavy-widget dashboard. Adds a plain style.

Test Plan:
Tested my homepage and dashboards

{F164709}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9454
---
 resources/celerity/map.php                      |  4 ++--
 ...PhabricatorDashboardPanelRenderingEngine.php |  4 ++--
 src/view/layout/PhabricatorActionHeaderView.php |  1 +
 .../layout/phabricator-action-header-view.css   | 17 +++++++++++++++++
 4 files changed, 22 insertions(+), 4 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 616cc33c6e..7acb9773f1 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -111,7 +111,7 @@ return array(
     'rsrc/css/font/font-awesome.css' => '73d075c3',
     'rsrc/css/font/font-source-sans-pro.css' => '91d53463',
     'rsrc/css/font/phui-font-icon-base.css' => 'eb84f033',
-    'rsrc/css/layout/phabricator-action-header-view.css' => 'ad0d8f42',
+    'rsrc/css/layout/phabricator-action-header-view.css' => 'e464b159',
     'rsrc/css/layout/phabricator-action-list-view.css' => 'dcbfc854',
     'rsrc/css/layout/phabricator-crumbs-view.css' => '7fbf25b8',
     'rsrc/css/layout/phabricator-filetree-view.css' => 'fccf9f82',
@@ -683,7 +683,7 @@ return array(
     'paste-css' => 'aa1767d1',
     'path-typeahead' => 'f7fc67ec',
     'people-profile-css' => 'ba7b2762',
-    'phabricator-action-header-view-css' => 'ad0d8f42',
+    'phabricator-action-header-view-css' => 'e464b159',
     'phabricator-action-list-view-css' => 'dcbfc854',
     'phabricator-application-launch-view-css' => '81bebcff',
     'phabricator-busy' => '6453c869',
diff --git a/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php b/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
index 6511f0fb39..1e8b3a0c31 100644
--- a/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
+++ b/src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
@@ -206,14 +206,14 @@ final class PhabricatorDashboardPanelRenderingEngine extends Phobject {
       case self::HEADER_MODE_EDIT:
         $header = id(new PhabricatorActionHeaderView())
           ->setHeaderTitle($panel->getName())
-          ->setHeaderColor(PhabricatorActionHeaderView::HEADER_LIGHTBLUE);
+          ->setHeaderColor(PhabricatorActionHeaderView::HEADER_WHITE);
         $header = $this->addPanelHeaderActions($header);
         break;
       case self::HEADER_MODE_NORMAL:
       default:
         $header = id(new PhabricatorActionHeaderView())
           ->setHeaderTitle($panel->getName())
-          ->setHeaderColor(PhabricatorActionHeaderView::HEADER_LIGHTBLUE);
+          ->setHeaderColor(PhabricatorActionHeaderView::HEADER_WHITE);
         break;
     }
     return $header;
diff --git a/src/view/layout/PhabricatorActionHeaderView.php b/src/view/layout/PhabricatorActionHeaderView.php
index 0446019a6a..a141b7ba7b 100644
--- a/src/view/layout/PhabricatorActionHeaderView.php
+++ b/src/view/layout/PhabricatorActionHeaderView.php
@@ -9,6 +9,7 @@ final class PhabricatorActionHeaderView extends AphrontView {
   const HEADER_RED = 'red';
   const HEADER_YELLOW = 'yellow';
   const HEADER_LIGHTBLUE ='lightblue';
+  const HEADER_WHITE = 'white';
 
   private $headerTitle;
   private $headerHref;
diff --git a/webroot/rsrc/css/layout/phabricator-action-header-view.css b/webroot/rsrc/css/layout/phabricator-action-header-view.css
index 96f21ea55d..53dcc7ae2f 100644
--- a/webroot/rsrc/css/layout/phabricator-action-header-view.css
+++ b/webroot/rsrc/css/layout/phabricator-action-header-view.css
@@ -64,6 +64,23 @@
   background: {$red};
 }
 
+.phabricator-action-header.gradient-white-header {
+  background: #fff;
+}
+
+.dashboard-panel .phabricator-action-header.gradient-white-header {
+  border: 1px solid {$lightblueborder};
+  border-bottom: 1px solid {$thinblueborder};
+  border-top-right-radius: 3px;
+  border-top-left-radius: 3px;
+}
+
+.phabricator-action-header.gradient-white-header .phabricator-action-header-title {
+  color: {$darkbluetext};
+  padding: 12px 0 12px 4px;
+}
+
+
 .gradient-green-header .phabricator-action-header-title,
 .gradient-red-header .phabricator-action-header-title,
 .gradient-blue-header .phabricator-action-header-title,