revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-21 04:01:30 +01:00
Code Issues Releases Wiki Activity

[Redesign] Render full priority names on Maniphest icons

Browse source 
Summary: Ref T8099, Adds more infomation to the icon in Maniphest Task Lists.

Test Plan: Hover over icons in a Maniphest Task

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13367
This commit is contained in:
Chad Little 2015-06-21 10:24:30 +01:00
parent 7787c50da9
commit 133263cec8
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/maniphest/view/ManiphestTaskListView.php
View file

@ -50,6 +50,7 @@ final class ManiphestTaskListView extends ManiphestView {
$status_map = ManiphestTaskStatus::getTaskStatusMap(); $status_map = ManiphestTaskStatus::getTaskStatusMap();
$color_map = ManiphestTaskPriority::getColorMap(); $color_map = ManiphestTaskPriority::getColorMap();
$priority_map = ManiphestTaskPriority::getTaskPriorityMap();
if ($this->showBatchControls) { if ($this->showBatchControls) {
Javelin::initBehavior('maniphest-list-editor'); Javelin::initBehavior('maniphest-list-editor');
@ -69,6 +70,10 @@ final class ManiphestTaskListView extends ManiphestView {
} }
$status = $task->getStatus(); $status = $task->getStatus();
$pri = idx($priority_map, $task->getPriority());
$status_name = idx($status_map, $task->getStatus());
$tooltip = pht('%s, %s', $status_name, $pri);
// TODO: redesign-2015 move icon map to maniphest.statuses // TODO: redesign-2015 move icon map to maniphest.statuses
$icon = 'fa-exclamation-circle '; $icon = 'fa-exclamation-circle ';
$icon .= idx($color_map, $task->getPriority(), 'grey'); $icon .= idx($color_map, $task->getPriority(), 'grey');
@ -76,7 +81,8 @@ final class ManiphestTaskListView extends ManiphestView {
$item->setDisabled(true); $item->setDisabled(true);
$icon = 'fa-check-square-o grey'; $icon = 'fa-check-square-o grey';
} }
$item->setStatusIcon($icon, idx($status_map, $task->getStatus()));
$item->setStatusIcon($icon, $tooltip);
$item->addIcon( $item->addIcon(
'none', 'none',

2
src/view/phui/PHUIObjectItemView.php
View file

@ -672,7 +672,7 @@ final class PHUIObjectItemView extends AphrontTagView {
if (strlen($label)) { if (strlen($label)) {
$options['sigil'] = 'has-tooltip'; $options['sigil'] = 'has-tooltip';
$options['meta'] = array('tip' => $label); $options['meta'] = array('tip' => $label, 'size' => 300);
} }
return javelin_tag('div', $options, $icon); return javelin_tag('div', $options, $icon);