From 13813d226847cd5bebc3aec2dd21c3975a3c1ed8 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 3 Mar 2016 15:18:41 -0800 Subject: [PATCH] Minor Ponder spacing updates Summary: Fix an issue where you've already answered, moved the summary section. Test Plan: Review an answer with a wiki that i've already answered Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D15395 --- resources/celerity/map.php | 4 ++-- .../ponder/controller/PonderQuestionViewController.php | 2 +- src/applications/ponder/view/PonderAddAnswerView.php | 3 ++- webroot/rsrc/css/application/ponder/ponder-view.css | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 50877bd5fc..be8d5b9d1c 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -92,7 +92,7 @@ return array( 'rsrc/css/application/policy/policy-edit.css' => '815c66f7', 'rsrc/css/application/policy/policy-transaction-detail.css' => '82100a43', 'rsrc/css/application/policy/policy.css' => '957ea14c', - 'rsrc/css/application/ponder/ponder-view.css' => '4e321d68', + 'rsrc/css/application/ponder/ponder-view.css' => 'fbd45f96', 'rsrc/css/application/project/project-card-view.css' => '9418c97d', 'rsrc/css/application/project/project-view.css' => '9ce99f21', 'rsrc/css/application/releeph/releeph-core.css' => '9b3c5733', @@ -857,7 +857,7 @@ return array( 'policy-css' => '957ea14c', 'policy-edit-css' => '815c66f7', 'policy-transaction-detail-css' => '82100a43', - 'ponder-view-css' => '4e321d68', + 'ponder-view-css' => 'fbd45f96', 'project-card-view-css' => '9418c97d', 'project-view-css' => '9ce99f21', 'releeph-core' => '9b3c5733', diff --git a/src/applications/ponder/controller/PonderQuestionViewController.php b/src/applications/ponder/controller/PonderQuestionViewController.php index 439119512b..41819a34f0 100644 --- a/src/applications/ponder/controller/PonderQuestionViewController.php +++ b/src/applications/ponder/controller/PonderQuestionViewController.php @@ -108,9 +108,9 @@ final class PonderQuestionViewController extends PonderController { 'class' => 'ponder-question-content', ), array( + $answer_wiki, $footer, $comment_view, - $answer_wiki, $answers, $answer_add_panel, )); diff --git a/src/applications/ponder/view/PonderAddAnswerView.php b/src/applications/ponder/view/PonderAddAnswerView.php index fb52bd17ed..989837aa94 100644 --- a/src/applications/ponder/view/PonderAddAnswerView.php +++ b/src/applications/ponder/view/PonderAddAnswerView.php @@ -22,13 +22,14 @@ final class PonderAddAnswerView extends AphrontView { $authors = mpull($question->getAnswers(), null, 'getAuthorPHID'); if (isset($authors[$viewer->getPHID()])) { - return id(new PHUIInfoView()) + $view = id(new PHUIInfoView()) ->setSeverity(PHUIInfoView::SEVERITY_NOTICE) ->setTitle(pht('Already Answered')) ->appendChild( pht( 'You have already answered this question. You can not answer '. 'twice, but you can edit your existing answer.')); + return phutil_tag_div('ponder-add-answer-view', $view); } $info_panel = null; diff --git a/webroot/rsrc/css/application/ponder/ponder-view.css b/webroot/rsrc/css/application/ponder/ponder-view.css index 8d0556ef87..966fb6a1fb 100644 --- a/webroot/rsrc/css/application/ponder/ponder-view.css +++ b/webroot/rsrc/css/application/ponder/ponder-view.css @@ -117,7 +117,7 @@ body .phui-main-column .ponder-question-content .ponder-answer-view } .ponder-answer-section { - margin-top: 32px; + margin-top: 48px; } .ponder-add-answer-header {