revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-04 00:18:21 +02:00
Code Issues Releases Wiki Activity

Fix project view and edit uris on creation

Browse source 
Summary: Fixes T6305, sets edit and view uris later in the stack.

Test Plan: Create and edit a project in /project/. Create a project in a dialog. Get redirected to correct place. Verify Cancel send you back to home.

Reviewers: epriestley, btrahan

Reviewed By: btrahan

Subscribers: Korvin, epriestley

Maniphest Tasks: T6305

Differential Revision: https://secure.phabricator.com/D10702
This commit is contained in:
Chad Little 2014-10-14 09:55:52 -07:00
parent af4ebc67c6
commit 13aa443e2d
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/applications/project/controller/PhabricatorProjectEditDetailsController.php
View file

@ -46,9 +46,6 @@ final class PhabricatorProjectEditDetailsController
->setViewer($viewer) ->setViewer($viewer)
->readFieldsFromStorage($project); ->readFieldsFromStorage($project);
$view_uri = $this->getApplicationURI('view/'.$project->getID().'/');
$edit_uri = $this->getApplicationURI('edit/'.$project->getID().'/');
$e_name = true; $e_name = true;
$e_slugs = false; $e_slugs = false;
$e_edit = null; $e_edit = null;
@ -151,9 +148,11 @@ final class PhabricatorProjectEditDetailsController
} }
if ($is_new) { if ($is_new) {
$redirect_uri = $view_uri; $redirect_uri =
$this->getApplicationURI('view/'.$project->getID().'/');
} else { } else {
$redirect_uri = $edit_uri; $redirect_uri =
$this->getApplicationURI('edit/'.$project->getID().'/');
} }
return id(new AphrontRedirectResponse())->setURI($redirect_uri); return id(new AphrontRedirectResponse())->setURI($redirect_uri);
@ -288,7 +287,7 @@ final class PhabricatorProjectEditDetailsController
$form->appendChild( $form->appendChild(
id(new AphrontFormSubmitControl()) id(new AphrontFormSubmitControl())
->addCancelButton($edit_uri) ->addCancelButton($this->getApplicationURI())
->setValue(pht('Save'))); ->setValue(pht('Save')));
$form_box = id(new PHUIObjectBoxView()) $form_box = id(new PHUIObjectBoxView())
@ -301,8 +300,10 @@ final class PhabricatorProjectEditDetailsController
$crumbs->addTextCrumb($title); $crumbs->addTextCrumb($title);
} else { } else {
$crumbs $crumbs
->addTextCrumb($project->getName(), $view_uri) ->addTextCrumb($project->getName(),
->addTextCrumb(pht('Edit'), $edit_uri) $this->getApplicationURI('view/'.$project->getID().'/'))
->addTextCrumb(pht('Edit'),
$this->getApplicationURI('edit/'.$project->getID().'/'))
->addTextCrumb(pht('Details')); ->addTextCrumb(pht('Details'));
} }