revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 04:20:55 +01:00
Code Issues Releases Wiki Activity

Force a couple of Conduit results to the proper types in Calendar

Browse source 
Summary:
Ref T11706. Add some casts so we don't return `"0"` for `false`.

Also I forgot to document one of the things.

Test Plan: Called `calendar.event.search`.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11706

Differential Revision: https://secure.phabricator.com/D16690
This commit is contained in:
epriestley 2016-10-11 12:32:32 -07:00
parent fa90f8bef4
commit 13b4b37d30
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/calendar/storage/PhabricatorCalendarEvent.php
View file

@ -1056,6 +1056,10 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
->setKey('description') ->setKey('description')
->setType('string') ->setType('string')
->setDescription(pht('The event description.')), ->setDescription(pht('The event description.')),
id(new PhabricatorConduitSearchFieldSpecification())
->setKey('isAllDay')
->setType('bool')
->setDescription(pht('True if the event is an all day event.')),
id(new PhabricatorConduitSearchFieldSpecification()) id(new PhabricatorConduitSearchFieldSpecification())
->setKey('startDateTime') ->setKey('startDateTime')
->setType('datetime') ->setType('datetime')
@ -1074,7 +1078,7 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
return array( return array(
'name' => $this->getName(), 'name' => $this->getName(),
'description' => $this->getDescription(), 'description' => $this->getDescription(),
'isAllDay' => $this->getIsAllDay(), 'isAllDay' => (bool)$this->getIsAllDay(),
'startDateTime' => $this->getConduitDateTime($start_datetime), 'startDateTime' => $this->getConduitDateTime($start_datetime),
'endDateTime' => $this->getConduitDateTime($end_datetime), 'endDateTime' => $this->getConduitDateTime($end_datetime),
); );
@ -1097,7 +1101,7 @@ final class PhabricatorCalendarEvent extends PhabricatorCalendarDAO
->overrideTimezoneIdentifier($this->viewerTimezone); ->overrideTimezoneIdentifier($this->viewerTimezone);
return array( return array(
'epoch' => $epoch, 'epoch' => (int)$epoch,
'display' => array( 'display' => array(
'default' => phabricator_datetime($epoch, $viewer), 'default' => phabricator_datetime($epoch, $viewer),
), ),