From 14198d62fb5b0179a48b75f16ee0ec6770a83323 Mon Sep 17 00:00:00 2001 From: James Rhodes Date: Wed, 11 Jun 2014 20:02:10 -0700 Subject: [PATCH] Return the build from applyPlan instead of the plan Summary: Nothing inside Phabricator uses the return value of this method, but returning the actual build instance is far more useful (for kicking off builds in an application and storing the build PHID against another object). Test Plan: N/A Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: epriestley, Korvin Differential Revision: https://secure.phabricator.com/D9494 --- src/applications/harbormaster/storage/HarbormasterBuildable.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/harbormaster/storage/HarbormasterBuildable.php b/src/applications/harbormaster/storage/HarbormasterBuildable.php index 9c7074ef57..f8b5d2d21f 100644 --- a/src/applications/harbormaster/storage/HarbormasterBuildable.php +++ b/src/applications/harbormaster/storage/HarbormasterBuildable.php @@ -123,7 +123,7 @@ final class HarbormasterBuildable extends HarbormasterDAO 'buildID' => $build->getID() )); - return $this; + return $build; } public function getConfiguration() {