revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-11 23:31:03 +01:00
Code Issues Releases Wiki Activity

Fix an excessively aggressive transaction check in Owners

Browse source 
Summary: Fixes T10058. We don't need to continue on this check if no path changes are being applied.

Test Plan: Archived an owners package.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10058

Differential Revision: https://secure.phabricator.com/D14906
This commit is contained in:
epriestley 2015-12-28 13:30:07 -08:00
parent 33384abff7
commit 1443e4b13d
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/owners/editor/PhabricatorOwnersPackageTransactionEditor.php
View file

@ -204,6 +204,10 @@ final class PhabricatorOwnersPackageTransactionEditor
} }
break; break;
case PhabricatorOwnersPackageTransaction::TYPE_PATHS: case PhabricatorOwnersPackageTransaction::TYPE_PATHS:
if (!$xactions) {
continue;
}
$old = mpull($object->getPaths(), 'getRef'); $old = mpull($object->getPaths(), 'getRef');
foreach ($xactions as $xaction) { foreach ($xactions as $xaction) {
$new = $xaction->getNewValue(); $new = $xaction->getNewValue();