Remove the legacy chart behavior from Maniphest

Summary: Depends on D20486. Ref T13279. Now that the "Reports" UI uses a panel to draw a real chart from Facts, throw away the copy of the old code.

Test Plan: `grep`

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13279

Differential Revision: https://secure.phabricator.com/D20487

resources/celerity/map.php

@@ -398,7 +398,6 @@ return array(
     'rsrc/js/application/herald/PathTypeahead.js' => 'ad486db3',
     'rsrc/js/application/herald/herald-rule-editor.js' => '0922e81d',
     'rsrc/js/application/maniphest/behavior-batch-selector.js' => '139ef688',
-    'rsrc/js/application/maniphest/behavior-line-chart-legacy.js' => 'faf3ab6b',
     'rsrc/js/application/maniphest/behavior-line-chart.js' => 'ad258e28',
     'rsrc/js/application/maniphest/behavior-list-edit.js' => 'c687e867',
     'rsrc/js/application/owners/OwnersPathEditor.js' => '2a8b62d9',
@@ -628,7 +627,6 @@ return array(
     'javelin-behavior-launch-icon-composer' => 'a17b84f1',
     'javelin-behavior-lightbox-attachments' => 'c7e748bf',
     'javelin-behavior-line-chart' => 'ad258e28',
-    'javelin-behavior-line-chart-legacy' => 'faf3ab6b',
     'javelin-behavior-linked-container' => '74446546',
     'javelin-behavior-maniphest-batch-selector' => '139ef688',
     'javelin-behavior-maniphest-list-editor' => 'c687e867',
@@ -2182,12 +2180,6 @@ return array(
     'fa74cc35' => array(
       'phui-oi-list-view-css',
     ),
-    'faf3ab6b' => array(
-      'javelin-behavior',
-      'javelin-dom',
-      'javelin-vector',
-      'phui-chart-css',
-    ),
     'fcb0c07d' => array(
       'phui-chart-css',
       'd3',

webroot/rsrc/js/application/maniphest/behavior-line-chart-legacy.js

@@ -1,126 +0,0 @@
-/**
- * @provides javelin-behavior-line-chart-legacy
- * @requires javelin-behavior
- *           javelin-dom
- *           javelin-vector
- *           phui-chart-css
- */
-
-JX.behavior('line-chart-legacy', function(config) {
-
-  function fn(n) {
-    return n + '(' + JX.$A(arguments).slice(1).join(', ') + ')';
-  }
-
-  var h = JX.$(config.hardpoint);
-  var d = JX.Vector.getDim(h);
-
-  var padding = {
-    top: 24,
-    left: 48,
-    bottom: 48,
-    right: 32
-  };
-
-  var size = {
-    frameWidth: d.x,
-    frameHeight: d.y,
-  };
-
-  size.width = size.frameWidth - padding.left - padding.right;
-  size.height = size.frameHeight - padding.top - padding.bottom;
-
-  var x = d3.time.scale()
-    .range([0, size.width]);
-
-  var y = d3.scale.linear()
-    .range([size.height, 0]);
-
-  var xAxis = d3.svg.axis()
-    .scale(x)
-    .orient('bottom');
-
-  var yAxis = d3.svg.axis()
-    .scale(y)
-    .orient('left');
-
-  var svg = d3.select('#' + config.hardpoint).append('svg')
-    .attr('width', size.frameWidth)
-    .attr('height', size.frameHeight)
-    .attr('class', 'chart');
-
-  var g = svg.append('g')
-      .attr('transform', fn('translate', padding.left, padding.top));
-
-  g.append('rect')
-      .attr('class', 'inner')
-      .attr('width', size.width)
-      .attr('height', size.height);
-
-  var line = d3.svg.line()
-    .x(function(d) { return x(d.date); })
-    .y(function(d) { return y(d.count); });
-
-  var data = [];
-  for (var ii = 0; ii < config.x[0].length; ii++) {
-    data.push(
-      {
-        date: new Date(config.x[0][ii] * 1000),
-        count: +config.y[0][ii]
-      });
-  }
-
-  x.domain(d3.extent(data, function(d) { return d.date; }));
-
-  var yex = d3.extent(data, function(d) { return d.count; });
-  yex[0] = 0;
-  yex[1] = yex[1] * 1.05;
-  y.domain(yex);
-
-  g.append('path')
-    .datum(data)
-    .attr('class', 'line')
-    .attr('d', line);
-
-  g.append('g')
-    .attr('class', 'x axis')
-    .attr('transform', fn('translate', 0, size.height))
-    .call(xAxis);
-
-  g.append('g')
-    .attr('class', 'y axis')
-    .attr('transform', fn('translate', 0, 0))
-    .call(yAxis);
-
-  var div = d3.select('body')
-    .append('div')
-    .attr('class', 'chart-tooltip')
-    .style('opacity', 0);
-
-  g.selectAll('dot')
-    .data(data)
-    .enter()
-    .append('circle')
-    .attr('class', 'point')
-    .attr('r', 3)
-    .attr('cx', function(d) { return x(d.date); })
-    .attr('cy', function(d) { return y(d.count); })
-    .on('mouseover', function(d) {
-      var d_y = d.date.getFullYear();
-
-      // NOTE: Javascript months are zero-based. See PHI1017.
-      var d_m = d.date.getMonth() + 1;
-
-      var d_d = d.date.getDate();
-
-      div
-        .html(d_y + '-' + d_m + '-' + d_d + ': ' + d.count)
-        .style('opacity', 0.9)
-        .style('left', (d3.event.pageX - 60) + 'px')
-        .style('top', (d3.event.pageY - 38) + 'px');
-      })
-    .on('mouseout', function() {
-      div.style('opacity', 0);
-    });
-
-});