revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity

Emit resize events after making document changes during inline editing

Browse source 
Summary:
Ref T12634. Fixes T12633. These events allow the keyboard reticle to resize properly.

(I expect to possibly hide/disable the reticle in the future during edits, but at least make the behavior sensible for now.)

Test Plan:
  - Used "n" to select a block.
  - Clicked a line number in that block to start a new inline comment.
  - Saw reticle resize properly.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12634, T12633

Differential Revision: https://secure.phabricator.com/D17904
This commit is contained in:
epriestley 2017-05-16 07:11:43 -07:00
parent 665ff4fdf6
commit 1493f08272
2 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
resources/celerity/map.php
View file

@ -13,7 +13,7 @@ return array(
'core.pkg.js' => '8c5f913d',
'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => '58712637',
'differential.pkg.js' => 'a185599e',
'differential.pkg.js' => '6ee9a850',
'diffusion.pkg.css' => 'b93d9b8c',
'diffusion.pkg.js' => '84c8f8fd',
'favicon.ico' => '30672e08',
@ -392,7 +392,7 @@ return array(
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
'rsrc/js/application/diff/DiffChangeset.js' => 'f7100923',
'rsrc/js/application/diff/DiffChangesetList.js' => 'e5c5e171',
'rsrc/js/application/diff/DiffInline.js' => 'f3af20b1',
'rsrc/js/application/diff/DiffInline.js' => '4bbefc49',
'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832',
'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d',
'rsrc/js/application/differential/behavior-comment-preview.js' => 'b064af76',
@ -783,7 +783,7 @@ return array(
'phabricator-dashboard-css' => 'fe5b1869',
'phabricator-diff-changeset' => 'f7100923',
'phabricator-diff-changeset-list' => 'e5c5e171',
'phabricator-diff-inline' => 'f3af20b1',
'phabricator-diff-inline' => '4bbefc49',
'phabricator-drag-and-drop-file-upload' => '58dea2fa',
'phabricator-draggable-list' => 'bea6e7f4',
'phabricator-fatal-config-template-css' => '8f18fa41',
@ -1259,6 +1259,9 @@ return array(
'javelin-util',
'phabricator-shaped-request',
),
'4bbefc49' => array(
'javelin-dom',
),
'4c193c96' => array(
'javelin-behavior',
'javelin-uri',
@ -2170,9 +2173,6 @@ return array(
'javelin-workflow',
'javelin-json',
),
'f3af20b1' => array(
'javelin-dom',
),
'f50152ad' => array(
'phui-timeline-view-css',
),

6
webroot/rsrc/js/application/diff/DiffInline.js
View file

@ -438,6 +438,8 @@ JX.install('DiffInline', {
row = next_row;
}
JX.Stratcom.invoke('resize');
return first_meta;
},
@ -516,6 +518,10 @@ JX.install('DiffInline', {
// After making changes to inline comments, refresh the transaction
// preview at the bottom of the page.
this.getChangeset().getChangesetList().redrawPreview();
// Emit a resize event so that UI elements like the keyboad focus
// reticle can redraw properly.
JX.Stratcom.invoke('resize');
},
_redraw: function() {