1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00

Style <h1> -> <h6> for Remarkup

Summary:
most users will notice this makes h1 and h2 bigger.

my design algorithm was to start with h6 and make that the
size of regular text and then gently scale upwards to the mighty
h1.  i used margins so things would collapse nice and first-child /
last-child so there wouldn't be any longer-than-planned spacing.

Test Plan:
made a few docs like

= header =

== sub header ==

=== sub sub header ===

(etc)

in phriction and they looked good to me.  made some comments
in differential like that and they looked good to me.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: 1094
This commit is contained in:
Bob Trahan 2011-11-09 12:14:12 -08:00
parent b71a55900a
commit 1494476d30
2 changed files with 162 additions and 112 deletions

View file

@ -211,69 +211,6 @@ celerity_register_resource_map(array(
),
'disk' => '/rsrc/css/application/differential/add-comment.css',
),
'differential-revision-comment-css' =>
array(
'uri' => '/res/9fb8013b/rsrc/css/application/differential/revision-comment.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-comment.css',
),
'differential-revision-comment-list-css' =>
array(
'uri' => '/res/3b31faa3/rsrc/css/application/differential/revision-comment-list.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-comment-list.css',
),
'differential-revision-detail-css' =>
array(
'uri' => '/res/caa89172/rsrc/css/application/differential/revision-detail.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-detail.css',
),
'differential-revision-history-css' =>
array(
'uri' => '/res/0d7d515d/rsrc/css/application/differential/revision-history.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-history.css',
),
'differential-table-of-contents-css' =>
array(
'uri' => '/res/d173445b/rsrc/css/application/differential/table-of-contents.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/table-of-contents.css',
),
'diffusion-commit-view-css' =>
array(
'uri' => '/res/bc39d876/rsrc/css/application/diffusion/commit-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/commit-view.css',
),
'diffusion-source-css' =>
array(
'uri' => '/res/db4566b6/rsrc/css/application/diffusion/diffusion-source.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/diffusion-source.css',
),
'files-css' =>
array(
'uri' => '/res/a265a77d/rsrc/css/application/files/files.css',
@ -292,25 +229,6 @@ celerity_register_resource_map(array(
),
'disk' => '/rsrc/css/application/herald/herald.css',
),
'herald-rule-editor' =>
array(
'uri' => '/res/4d6dff2b/rsrc/js/application/herald/HeraldRuleEditor.js',
'type' => 'js',
'requires' =>
array(
0 => 'multirow-row-manager',
1 => 'javelin-install',
2 => 'javelin-typeahead',
3 => 'javelin-util',
4 => 'javelin-dom',
5 => 'javelin-tokenizer',
6 => 'javelin-typeahead-preloaded-source',
7 => 'javelin-stratcom',
8 => 'javelin-json',
9 => 'phabricator-prefab',
),
'disk' => '/rsrc/js/application/herald/HeraldRuleEditor.js',
),
'herald-test-css' =>
array(
'uri' => '/res/c0cd6bdb/rsrc/css/application/herald/herald-test.css',
@ -395,6 +313,99 @@ celerity_register_resource_map(array(
),
'disk' => '/rsrc/js/application/countdown/timer.js',
),
0 =>
array(
'uri' => '/res/b6096fdd/rsrc/js/javelin/lib/__tests__/URI.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-uri',
1 => 'javelin-php-serializer',
),
'disk' => '/rsrc/js/javelin/lib/__tests__/URI.js',
),
'differential-revision-comment-css' =>
array(
'uri' => '/res/9fb8013b/rsrc/css/application/differential/revision-comment.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-comment.css',
),
'differential-revision-comment-list-css' =>
array(
'uri' => '/res/3b31faa3/rsrc/css/application/differential/revision-comment-list.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-comment-list.css',
),
'differential-revision-detail-css' =>
array(
'uri' => '/res/caa89172/rsrc/css/application/differential/revision-detail.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-detail.css',
),
'differential-revision-history-css' =>
array(
'uri' => '/res/0d7d515d/rsrc/css/application/differential/revision-history.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/revision-history.css',
),
'differential-table-of-contents-css' =>
array(
'uri' => '/res/d173445b/rsrc/css/application/differential/table-of-contents.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/differential/table-of-contents.css',
),
'diffusion-commit-view-css' =>
array(
'uri' => '/res/bc39d876/rsrc/css/application/diffusion/commit-view.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/commit-view.css',
),
'diffusion-source-css' =>
array(
'uri' => '/res/db4566b6/rsrc/css/application/diffusion/diffusion-source.css',
'type' => 'css',
'requires' =>
array(
),
'disk' => '/rsrc/css/application/diffusion/diffusion-source.css',
),
'herald-rule-editor' =>
array(
'uri' => '/res/4d6dff2b/rsrc/js/application/herald/HeraldRuleEditor.js',
'type' => 'js',
'requires' =>
array(
0 => 'multirow-row-manager',
1 => 'javelin-install',
2 => 'javelin-typeahead',
3 => 'javelin-util',
4 => 'javelin-dom',
5 => 'javelin-tokenizer',
6 => 'javelin-typeahead-preloaded-source',
7 => 'javelin-stratcom',
8 => 'javelin-json',
9 => 'phabricator-prefab',
),
'disk' => '/rsrc/js/application/herald/HeraldRuleEditor.js',
),
'javelin-behavior-dark-console' =>
array(
'uri' => '/res/c80156c4/rsrc/js/application/core/behavior-dark-console.js',
@ -819,16 +830,6 @@ celerity_register_resource_map(array(
),
'disk' => '/rsrc/js/javelin/ext/reactor/core/DynVal.js',
),
0 =>
array(
'uri' => '/res/11520eb6/rsrc/js/javelin/lib/__tests__/JSON.js',
'type' => 'js',
'requires' =>
array(
0 => 'javelin-json',
),
'disk' => '/rsrc/js/javelin/lib/__tests__/JSON.js',
),
'javelin-event' =>
array(
'uri' => '/res/f42fa6ea/rsrc/js/javelin/core/Event.js',
@ -1393,7 +1394,7 @@ celerity_register_resource_map(array(
),
'phabricator-remarkup-css' =>
array(
'uri' => '/res/4305dda8/rsrc/css/core/remarkup.css',
'uri' => '/res/d0d50cdc/rsrc/css/core/remarkup.css',
'type' => 'css',
'requires' =>
array(
@ -1712,7 +1713,7 @@ celerity_register_resource_map(array(
'uri' => '/res/pkg/bbe7e6f7/typeahead.pkg.js',
'type' => 'js',
),
'fe6ae106' =>
'fa189780' =>
array(
'name' => 'core.pkg.css',
'symbols' =>
@ -1733,21 +1734,21 @@ celerity_register_resource_map(array(
13 => 'phabricator-remarkup-css',
14 => 'syntax-highlighting-css',
),
'uri' => '/res/pkg/fe6ae106/core.pkg.css',
'uri' => '/res/pkg/fa189780/core.pkg.css',
'type' => 'css',
),
),
'reverse' =>
array(
'aphront-crumbs-view-css' => 'fe6ae106',
'aphront-dialog-view-css' => 'fe6ae106',
'aphront-form-view-css' => 'fe6ae106',
'aphront-list-filter-view-css' => 'fe6ae106',
'aphront-panel-view-css' => 'fe6ae106',
'aphront-side-nav-view-css' => 'fe6ae106',
'aphront-table-view-css' => 'fe6ae106',
'aphront-tokenizer-control-css' => 'fe6ae106',
'aphront-typeahead-control-css' => 'fe6ae106',
'aphront-crumbs-view-css' => 'fa189780',
'aphront-dialog-view-css' => 'fa189780',
'aphront-form-view-css' => 'fa189780',
'aphront-list-filter-view-css' => 'fa189780',
'aphront-panel-view-css' => 'fa189780',
'aphront-side-nav-view-css' => 'fa189780',
'aphront-table-view-css' => 'fa189780',
'aphront-tokenizer-control-css' => 'fa189780',
'aphront-typeahead-control-css' => 'fa189780',
'differential-changeset-view-css' => '6ed92e8c',
'differential-core-view-css' => '6ed92e8c',
'differential-revision-add-comment-css' => '6ed92e8c',
@ -1784,13 +1785,13 @@ celerity_register_resource_map(array(
'javelin-util' => '22c00e0e',
'javelin-vector' => '22c00e0e',
'javelin-workflow' => '2d40bd98',
'phabricator-core-buttons-css' => 'fe6ae106',
'phabricator-core-css' => 'fe6ae106',
'phabricator-directory-css' => 'fe6ae106',
'phabricator-core-buttons-css' => 'fa189780',
'phabricator-core-css' => 'fa189780',
'phabricator-directory-css' => 'fa189780',
'phabricator-keyboard-shortcut' => '2d40bd98',
'phabricator-keyboard-shortcut-manager' => '2d40bd98',
'phabricator-remarkup-css' => 'fe6ae106',
'phabricator-standard-page-view' => 'fe6ae106',
'syntax-highlighting-css' => 'fe6ae106',
'phabricator-remarkup-css' => 'fa189780',
'phabricator-standard-page-view' => 'fa189780',
'syntax-highlighting-css' => 'fa189780',
),
));

View file

@ -43,9 +43,58 @@
margin: 1em 0 1em 3em;
}
.phabricator-remarkup h1,
.phabricator-remarkup h1:first-child,
.phabricator-remarkup h2:first-child,
.phabricator-remarkup h3:first-child,
.phabricator-remarkup h4:first-child,
.phabricator-remarkup h5:first-child,
.phabricator-remarkup h6:first-child {
margin-top: 0;
}
.phabricator-remarkup h1:last-child,
.phabricator-remarkup h2:last-child,
.phabricator-remarkup h3:last-child,
.phabricator-remarkup h4:last-child,
.phabricator-remarkup h5:last-child,
.phabricator-remarkup h6:last-child {
margin-bottom: 0;
}
.phabricator-remarkup h1 {
font-size: 1.625em;
line-height: 1.625em;
margin: .8em0 0 .8em;
}
.phabricator-remarkup h2 {
margin: .75em 0 .5em;
font-size: 1.5em;
line-height: 1.5em;
margin: .75em 0 .75em;
}
.phabricator-remarkup h3 {
font-size: 1.375em;
line-height: 1.375em;
margin: .69em 0 .69em;
}
.phabricator-remarkup h4 {
font-size: 1.25em;
line-height: 1.25em;
margin: .63em 0 .63em;
}
.phabricator-remarkup h5 {
font-size: 1.125em;
line-height: 1.125em;
margin: .56em 0 .56em;
}
.phabricator-remarkup h6 {
font-size: 1em;
line-height: 1em;
margin: .5em 0 .5em;
}
.phabricator-remarkup blockquote {