From 14fe3f5d14265b70d217da885d4c635b90c589f9 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 3 Oct 2012 12:39:18 -0700
Subject: [PATCH] Implement getHelpURI() for new applications

Summary: A bunch of recently-created applications have help available; link to it.

Test Plan: Clicked each app, clicked help link in menu bar, ended up in relevant documentation.

Reviewers: vrana, btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3602
---
 src/applications/base/PhabricatorApplication.php             | 5 -----
 .../conduit/application/PhabricatorApplicationConduit.php    | 5 +++++
 .../herald/application/PhabricatorApplicationHerald.php      | 4 ++++
 .../owners/application/PhabricatorApplicationOwners.php      | 4 ++++
 .../phame/application/PhabricatorApplicationPhame.php        | 4 ++++
 .../slowvote/application/PhabricatorApplicationSlowvote.php  | 5 +++++
 6 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php
index 547e0f66fa..caaf4ac053 100644
--- a/src/applications/base/PhabricatorApplication.php
+++ b/src/applications/base/PhabricatorApplication.php
@@ -77,13 +77,8 @@ abstract class PhabricatorApplication {
   public function getHelpURI() {
     // TODO: When these applications get created, link to their docs:
     //
-    //  - Conduit
     //  - Drydock
-    //  - Herald
     //  - OAuth Server
-    //  - Owners
-    //  - Phame
-    //  - Slowvote
 
 
     return null;
diff --git a/src/applications/conduit/application/PhabricatorApplicationConduit.php b/src/applications/conduit/application/PhabricatorApplicationConduit.php
index 3331808a2a..e89f25cdd2 100644
--- a/src/applications/conduit/application/PhabricatorApplicationConduit.php
+++ b/src/applications/conduit/application/PhabricatorApplicationConduit.php
@@ -26,6 +26,11 @@ final class PhabricatorApplicationConduit extends PhabricatorApplication {
     return 'conduit';
   }
 
+  public function getHelpURI() {
+    return PhabricatorEnv::getDoclink(
+      'article/Conduit_Technical_Documentation.html');
+  }
+
   public function getShortDescription() {
     return 'Conduit API Console';
   }
diff --git a/src/applications/herald/application/PhabricatorApplicationHerald.php b/src/applications/herald/application/PhabricatorApplicationHerald.php
index 52c9984551..8b775796d3 100644
--- a/src/applications/herald/application/PhabricatorApplicationHerald.php
+++ b/src/applications/herald/application/PhabricatorApplicationHerald.php
@@ -34,6 +34,10 @@ final class PhabricatorApplicationHerald extends PhabricatorApplication {
     return "\xE2\x98\xBF";
   }
 
+  public function getHelpURI() {
+    return PhabricatorEnv::getDoclink('article/Herald_User_Guide.html');
+  }
+
   public function getRoutes() {
     return array(
       '/herald/' => array(
diff --git a/src/applications/owners/application/PhabricatorApplicationOwners.php b/src/applications/owners/application/PhabricatorApplicationOwners.php
index bf38c0ce5f..a3fbe3b848 100644
--- a/src/applications/owners/application/PhabricatorApplicationOwners.php
+++ b/src/applications/owners/application/PhabricatorApplicationOwners.php
@@ -34,6 +34,10 @@ final class PhabricatorApplicationOwners extends PhabricatorApplication {
     return "\xE2\x98\x81";
   }
 
+  public function getHelpURI() {
+    return PhabricatorEnv::getDoclink('article/Owners_Tool_User_Guide.html');
+  }
+
   public function getRoutes() {
     return array(
       '/owners/' => array(
diff --git a/src/applications/phame/application/PhabricatorApplicationPhame.php b/src/applications/phame/application/PhabricatorApplicationPhame.php
index 21197db467..e05e951487 100644
--- a/src/applications/phame/application/PhabricatorApplicationPhame.php
+++ b/src/applications/phame/application/PhabricatorApplicationPhame.php
@@ -34,6 +34,10 @@ final class PhabricatorApplicationPhame extends PhabricatorApplication {
     return "\xe2\x9c\xa9";
   }
 
+  public function getHelpURI() {
+    return PhabricatorEnv::getDoclink('article/Phame_User_Guide.html');
+  }
+
   public function getRoutes() {
     return array(
      '/phame/' => array(
diff --git a/src/applications/slowvote/application/PhabricatorApplicationSlowvote.php b/src/applications/slowvote/application/PhabricatorApplicationSlowvote.php
index 671a2568d4..78f32958ab 100644
--- a/src/applications/slowvote/application/PhabricatorApplicationSlowvote.php
+++ b/src/applications/slowvote/application/PhabricatorApplicationSlowvote.php
@@ -34,6 +34,11 @@ final class PhabricatorApplicationSlowvote extends PhabricatorApplication {
     return "\xE2\x9C\x94";
   }
 
+  public function getHelpURI() {
+    return PhabricatorEnv::getDoclink('article/Slowvote_User_Guide.html');
+  }
+
+
   public function getRoutes() {
     return array(
       '/V(?P<id>\d+)' => 'PhabricatorSlowvotePollController',