1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 13:30:55 +01:00

Fix bad array index test in Differential package code

Summary: This needs an `isset()` for cases when authority and packages don't completely overlap.

Test Plan:
  - With a package set to trigger autoreview, created a revision.
  - Observed error log, saw no more error.
  - Saw package trigger autoreview properly.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D16398
This commit is contained in:
epriestley 2016-08-14 13:04:45 -07:00
parent 8c41226624
commit 15021a0bcc

View file

@ -1533,7 +1533,7 @@ final class DifferentialTransactionEditor
foreach ($packages as $key => $package) {
$package_phid = $package->getPHID();
if ($authority[$package_phid]) {
if (isset($authority[$package_phid])) {
unset($packages[$key]);
continue;
}