revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-08 22:01:03 +01:00
Code Issues Releases Wiki Activity

Fix bad array index test in Differential package code

Browse source 
Summary: This needs an `isset()` for cases when authority and packages don't completely overlap.

Test Plan:
  - With a package set to trigger autoreview, created a revision.
  - Observed error log, saw no more error.
  - Saw package trigger autoreview properly.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D16398
This commit is contained in:
epriestley 2016-08-14 13:04:45 -07:00
parent 8c41226624
commit 15021a0bcc
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/editor/DifferentialTransactionEditor.php
View file

@ -1533,7 +1533,7 @@ final class DifferentialTransactionEditor
foreach ($packages as $key => $package) { foreach ($packages as $key => $package) {
$package_phid = $package->getPHID(); $package_phid = $package->getPHID();
if ($authority[$package_phid]) { if (isset($authority[$package_phid])) {
unset($packages[$key]); unset($packages[$key]);
continue; continue;
} }