From 15f14d6c2f207a471d8095cb2a365eaa51ced9a5 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 11 May 2016 17:01:52 -0700 Subject: [PATCH] Fix improper viewer for Git SSH cluster workflows Summary: Ref T10751. These workflows have separate `getUser()` and `getViewer()` for weird legacy reasons. `getUser()` is correct. Test Plan: - Did a Git SSH push, verified that "Last Writer" reflected the proper user in the "Storage" UI in repository management. - Grepped for other callsites, double-checked that they used correct users. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10751 Differential Revision: https://secure.phabricator.com/D15893 --- .../diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php b/src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php index 17d3badaa5..76f8d3c837 100644 --- a/src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php +++ b/src/applications/diffusion/ssh/DiffusionGitReceivePackSSHWorkflow.php @@ -15,7 +15,7 @@ final class DiffusionGitReceivePackSSHWorkflow extends DiffusionGitSSHWorkflow { protected function executeRepositoryOperations() { $repository = $this->getRepository(); - $viewer = $this->getViewer(); + $viewer = $this->getUser(); $device = AlmanacKeys::getLiveDevice(); // This is a write, and must have write access.