From 167e58479cd5fa20dcf9d225cb6370956cb2eb4b Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 11 Apr 2017 10:54:46 -0700 Subject: [PATCH] (stable) Remove 'isPartial' parameter with no effect Summary: Fixes T12536. Nothing reads this parameter; `PhabricatorFile::newChunkedFile` sets the `isPartial` flag automatically. Test Plan: Grepped for `isPartial`. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12536 Differential Revision: https://secure.phabricator.com/D17654 --- .../files/uploadsource/PhabricatorFileUploadSource.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/applications/files/uploadsource/PhabricatorFileUploadSource.php b/src/applications/files/uploadsource/PhabricatorFileUploadSource.php index b4578e9e56..0ef33a2521 100644 --- a/src/applications/files/uploadsource/PhabricatorFileUploadSource.php +++ b/src/applications/files/uploadsource/PhabricatorFileUploadSource.php @@ -137,10 +137,6 @@ abstract class PhabricatorFileUploadSource $parameters = $this->getNewFileParameters(); - $parameters = array( - 'isPartial' => true, - ) + $parameters; - $data_length = $this->getDataLength(); if ($data_length !== null) { $length = $data_length;