From 16accb591cc11e8a3cb064b98361d4539a9f31f0 Mon Sep 17 00:00:00 2001 From: Edward Speyer Date: Mon, 18 Feb 2013 16:58:35 +0000 Subject: [PATCH] STRICT_ALL_TABLES fix for a Herald column Summary: Casting a PHP bool to a MySQL `TINYINT(1)`! Test Plan: This broke during arc diff; with this patch, arc diff now works! Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4999 --- src/applications/herald/engine/HeraldEngine.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/herald/engine/HeraldEngine.php b/src/applications/herald/engine/HeraldEngine.php index 16f7bcad00..f898cd7a07 100644 --- a/src/applications/herald/engine/HeraldEngine.php +++ b/src/applications/herald/engine/HeraldEngine.php @@ -110,7 +110,7 @@ final class HeraldEngine { assert_instances_of($effects, 'HeraldEffect'); assert_instances_of($rules, 'HeraldRule'); - $this->transcript->setDryRun($object instanceof HeraldDryRunAdapter); + $this->transcript->setDryRun((int)($object instanceof HeraldDryRunAdapter)); $xscripts = $object->applyHeraldEffects($effects); foreach ($xscripts as $apply_xscript) {