revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-04 20:01:00 +01:00
Code Issues Releases Wiki Activity

Remove break from hunk migration

Browse source 
Summary: This `break` statement causes `./bin/hunks migrate` to only migrate one-hunk-at-a-time, which is unnecessary and slightly misleading. Instead, allow the script to migrate //all// legacy hunks to modern storage. In particular, this means that we can recommend that installs run this command sometime before D13222 is landed.

Test Plan: It's a pain to setup the data necessary to test this, but this is identical to the change that I made on our production install when I migrated our hunk storage.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13288
This commit is contained in:
Joshua Spence 2015-06-15 08:32:08 +10:00
parent 32f4c962fc
commit 175799fab9
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php
View file

@ -48,8 +48,6 @@ final class PhabricatorHunksManagementMigrateWorkflow
new PhutilNumber($diff_len), new PhutilNumber($diff_len),
sprintf('%.1f%%', 100 * ($diff_len / $old_len)))); sprintf('%.1f%%', 100 * ($diff_len / $old_len))));
} }
break;
} }
if ($saw_any_rows) { if ($saw_any_rows) {