From 17ced84ace331ab7a2b790cf62496c8d28c95c4f Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Tue, 17 Feb 2015 14:19:33 -0800 Subject: [PATCH] OAuth - make sure users know they are exposing their primary email address Summary: Fixes T7263. Last bit there was to upgrade this dialogue to let users know they are letting their primary email address be exposed in these flows. Depends on D11791, D11792, at least in terms of being accurate to the user as the code ended up strangely decoupled. Test Plan: wordsmithin' Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T7263 Differential Revision: https://secure.phabricator.com/D11793 --- .../controller/PhabricatorOAuthServerAuthController.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php b/src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php index 07e0e45425..4ff83b4d5f 100644 --- a/src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php +++ b/src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php @@ -244,7 +244,8 @@ final class PhabricatorOAuthServerAuthController ->appendParagraph( pht( 'Do you want to authorize the external application "%s" to '. - 'access your Phabricator account data?', + 'access your Phabricator account data, including your primary '. + 'email address?', phutil_tag('strong', array(), $name))) ->appendChild($form->buildLayoutView()) ->addSubmitButton(pht('Authorize Access'))