revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf

Browse source 
Summary:
Explicitly mentioning PHP5 packages is outdated and confusing.
Also, mentioning dnf together with yum (apparently yum is still in use!). Good for yum users.

Closes T15352

Test Plan: Applied this change and strings on the "Missing Required Extensions" page rendered as expected.

Reviewers: O1 Blessed Committers, valerio.bozzolan, jgleeson

Reviewed By: O1 Blessed Committers, valerio.bozzolan, jgleeson

Subscribers: jgleeson, bfs, speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15352

Differential Revision: https://we.phorge.it/D25203
This commit is contained in:
Andre Klapper 2023-05-20 17:45:54 +02:00
parent f97c9d68d0
commit 17ebf3a11f
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/applications/config/view/PhabricatorSetupIssueView.php
View file

@ -73,20 +73,22 @@ final class PhabricatorSetupIssueView extends AphrontView {
'Install these %d PHP extension(s):', count($extensions)); 'Install these %d PHP extension(s):', count($extensions));
$install_info = pht( $install_info = pht(
'You can usually install a PHP extension using %s or %s. Common '. 'You can usually install a PHP extension using %s, %s, or %s. A '.
'package names are %s or %s. Try commands like these:', 'common package name is %s. Try commands like these:',
phutil_tag('tt', array(), 'apt-get'), phutil_tag('tt', array(), 'apt-get'),
phutil_tag('tt', array(), 'dnf'),
phutil_tag('tt', array(), 'yum'), phutil_tag('tt', array(), 'yum'),
hsprintf('<tt>php-<em>%s</em></tt>', pht('extname')), hsprintf('<tt>php-<em>%s</em></tt>', pht('extname')));
hsprintf('<tt>php5-<em>%s</em></tt>', pht('extname')));
// TODO: We should do a better job of detecting how to install extensions // TODO: We should do a better job of detecting how to install extensions
// on the current system. // on the current system.
$install_commands = hsprintf( $install_commands = hsprintf(
"\$ sudo apt-get install php5-<em>extname</em> ". "\$ sudo apt-get install php-<em>extname</em> ".
"# Debian / Ubuntu\n". "# Debian / Ubuntu\n".
"\$ sudo yum install php-<em>extname</em> ". "\$ sudo dnf install php-<em>extname</em> ".
"# Red Hat / Derivatives"); "# Red Hat / Derivatives\n".
"\$ sudo yum install php-<em>extname</em> ".
"# Older Red Hat versions");
$fallback_info = pht( $fallback_info = pht(
"If those commands don't work, try Google. The process of installing ". "If those commands don't work, try Google. The process of installing ".