mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-29 10:12:41 +01:00
Add aural section headers for "Event Timeline", "Add Comment", and "Comment Preview"
Summary: See PHI871. Ref T13197. These sections are only divided visually and don't have textual headers. Add aural headers. Test Plan: {F5875471} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13197 Differential Revision: https://secure.phabricator.com/D19654
This commit is contained in:
parent
8eb8e8e1d8
commit
185e72c881
5 changed files with 36 additions and 12 deletions
|
@ -423,7 +423,7 @@ return array(
|
||||||
'rsrc/js/application/search/behavior-reorder-profile-menu-items.js' => 'e2e0a072',
|
'rsrc/js/application/search/behavior-reorder-profile-menu-items.js' => 'e2e0a072',
|
||||||
'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
|
'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
|
||||||
'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f',
|
'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f',
|
||||||
'rsrc/js/application/transactions/behavior-comment-actions.js' => '54110499',
|
'rsrc/js/application/transactions/behavior-comment-actions.js' => '038bf27f',
|
||||||
'rsrc/js/application/transactions/behavior-reorder-configs.js' => 'd7a74243',
|
'rsrc/js/application/transactions/behavior-reorder-configs.js' => 'd7a74243',
|
||||||
'rsrc/js/application/transactions/behavior-reorder-fields.js' => 'b59e1e96',
|
'rsrc/js/application/transactions/behavior-reorder-fields.js' => 'b59e1e96',
|
||||||
'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '8f29b364',
|
'rsrc/js/application/transactions/behavior-show-older-transactions.js' => '8f29b364',
|
||||||
|
@ -575,7 +575,7 @@ return array(
|
||||||
'javelin-behavior-bulk-job-reload' => 'edf8a145',
|
'javelin-behavior-bulk-job-reload' => 'edf8a145',
|
||||||
'javelin-behavior-calendar-month-view' => 'fe33e256',
|
'javelin-behavior-calendar-month-view' => 'fe33e256',
|
||||||
'javelin-behavior-choose-control' => '327a00d1',
|
'javelin-behavior-choose-control' => '327a00d1',
|
||||||
'javelin-behavior-comment-actions' => '54110499',
|
'javelin-behavior-comment-actions' => '038bf27f',
|
||||||
'javelin-behavior-config-reorder-fields' => 'b6993408',
|
'javelin-behavior-config-reorder-fields' => 'b6993408',
|
||||||
'javelin-behavior-conpherence-menu' => '4047cd35',
|
'javelin-behavior-conpherence-menu' => '4047cd35',
|
||||||
'javelin-behavior-conpherence-participant-pane' => 'd057e45a',
|
'javelin-behavior-conpherence-participant-pane' => 'd057e45a',
|
||||||
|
@ -905,6 +905,15 @@ return array(
|
||||||
'javelin-behavior',
|
'javelin-behavior',
|
||||||
'javelin-uri',
|
'javelin-uri',
|
||||||
),
|
),
|
||||||
|
'038bf27f' => array(
|
||||||
|
'javelin-behavior',
|
||||||
|
'javelin-stratcom',
|
||||||
|
'javelin-workflow',
|
||||||
|
'javelin-dom',
|
||||||
|
'phuix-form-control-view',
|
||||||
|
'phuix-icon-view',
|
||||||
|
'javelin-behavior-phabricator-gesture',
|
||||||
|
),
|
||||||
'040fce04' => array(
|
'040fce04' => array(
|
||||||
'javelin-behavior',
|
'javelin-behavior',
|
||||||
'javelin-request',
|
'javelin-request',
|
||||||
|
@ -1251,15 +1260,6 @@ return array(
|
||||||
'javelin-vector',
|
'javelin-vector',
|
||||||
'javelin-typeahead-static-source',
|
'javelin-typeahead-static-source',
|
||||||
),
|
),
|
||||||
54110499 => array(
|
|
||||||
'javelin-behavior',
|
|
||||||
'javelin-stratcom',
|
|
||||||
'javelin-workflow',
|
|
||||||
'javelin-dom',
|
|
||||||
'phuix-form-control-view',
|
|
||||||
'phuix-icon-view',
|
|
||||||
'javelin-behavior-phabricator-gesture',
|
|
||||||
),
|
|
||||||
'549459b8' => array(
|
'549459b8' => array(
|
||||||
'javelin-behavior',
|
'javelin-behavior',
|
||||||
),
|
),
|
||||||
|
|
|
@ -83,7 +83,15 @@ final class PhabricatorApplicationTransactionResponse
|
||||||
$xactions[$key] = hsprintf('%s', $xaction);
|
$xactions[$key] = hsprintf('%s', $xaction);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
$aural = phutil_tag(
|
||||||
|
'h3',
|
||||||
|
array(
|
||||||
|
'class' => 'aural-only',
|
||||||
|
),
|
||||||
|
pht('Comment Preview'));
|
||||||
|
|
||||||
$content = array(
|
$content = array(
|
||||||
|
'header' => hsprintf('%s', $aural),
|
||||||
'xactions' => $xactions,
|
'xactions' => $xactions,
|
||||||
'spacer' => PHUITimelineView::renderSpacer(),
|
'spacer' => PHUITimelineView::renderSpacer(),
|
||||||
'previewContent' => hsprintf('%s', $this->getPreviewContent()),
|
'previewContent' => hsprintf('%s', $this->getPreviewContent()),
|
||||||
|
|
|
@ -245,6 +245,13 @@ class PhabricatorApplicationTransactionCommentView extends AphrontView {
|
||||||
->setFlush(true)
|
->setFlush(true)
|
||||||
->addClass('phui-comment-form-view')
|
->addClass('phui-comment-form-view')
|
||||||
->addSigil('phui-comment-form')
|
->addSigil('phui-comment-form')
|
||||||
|
->appendChild(
|
||||||
|
phutil_tag(
|
||||||
|
'h3',
|
||||||
|
array(
|
||||||
|
'class' => 'aural-only',
|
||||||
|
),
|
||||||
|
pht('Add Comment')))
|
||||||
->appendChild($image)
|
->appendChild($image)
|
||||||
->appendChild($badge_view)
|
->appendChild($badge_view)
|
||||||
->appendChild($wedge)
|
->appendChild($wedge)
|
||||||
|
|
|
@ -83,7 +83,15 @@ final class PHUITimelineView extends AphrontView {
|
||||||
'class' => 'phui-timeline-view',
|
'class' => 'phui-timeline-view',
|
||||||
'id' => $this->id,
|
'id' => $this->id,
|
||||||
),
|
),
|
||||||
$events);
|
array(
|
||||||
|
phutil_tag(
|
||||||
|
'h3',
|
||||||
|
array(
|
||||||
|
'class' => 'aural-only',
|
||||||
|
),
|
||||||
|
pht('Event Timeline')),
|
||||||
|
$events,
|
||||||
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
public function buildEvents() {
|
public function buildEvents() {
|
||||||
|
|
|
@ -105,6 +105,7 @@ JX.behavior('comment-actions', function(config) {
|
||||||
JX.DOM.setContent(
|
JX.DOM.setContent(
|
||||||
preview_root,
|
preview_root,
|
||||||
[
|
[
|
||||||
|
JX.$H(response.header),
|
||||||
JX.$H(response.xactions.join('')),
|
JX.$H(response.xactions.join('')),
|
||||||
JX.$H(response.previewContent)
|
JX.$H(response.previewContent)
|
||||||
]);
|
]);
|
||||||
|
|
Loading…
Reference in a new issue