revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exception when received email lacks From header

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php:527]
```

Closes T15767

Test Plan: See T15767

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15767

Differential Revision: https://we.phorge.it/D25564
This commit is contained in:
Andre Klapper 2024-03-31 13:54:49 +02:00
parent 5263d5d590
commit 186768ccfd
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php
View file

@ -524,7 +524,7 @@ EOBODY
public function newFromAddress() { public function newFromAddress() {
$raw_from = $this->getHeader('From'); $raw_from = $this->getHeader('From');
if (strlen($raw_from)) { if (phutil_nonempty_string($raw_from)) {
return new PhutilEmailAddress($raw_from); return new PhutilEmailAddress($raw_from);
} }