mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 16:22:43 +01:00
Fix PHP 8.1 "strlen(null)" exception when received email lacks From header
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php:527] ``` Closes T15767 Test Plan: See T15767 Reviewers: O1 Blessed Committers, avivey Reviewed By: O1 Blessed Committers, avivey Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15767 Differential Revision: https://we.phorge.it/D25564
This commit is contained in:
parent
5263d5d590
commit
186768ccfd
1 changed files with 1 additions and 1 deletions
|
@ -524,7 +524,7 @@ EOBODY
|
|||
public function newFromAddress() {
|
||||
$raw_from = $this->getHeader('From');
|
||||
|
||||
if (strlen($raw_from)) {
|
||||
if (phutil_nonempty_string($raw_from)) {
|
||||
return new PhutilEmailAddress($raw_from);
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue