revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 10:12:41 +01:00
Code Issues Releases Wiki Activity

Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"

Browse source 
Summary:
Ref T13519. See <https://discourse.phabricator-community.org/t/error-call-to-undefined-method-differentialchangesetquery-withphids/3816/>.

Changesets do not have PHIDs, and the Query has no "withPHIDs()" method. The keys in the viewstate storage are (usually) IDs.

Test Plan:
  - On a revision with Diff 1 and Diff 2 affecting the same file:
    - Viewed Diff 1.
    - Hid file A.
    - Viewed Diff 2.
  - Before patch: exception about call to "withPHIDs()", which does not exist for ChangesetQuery.
  - After patch: no exception. Also, file actually unhid, which is the correct behavior!

Maniphest Tasks: T13519

Differential Revision: https://secure.phabricator.com/D21189
This commit is contained in:
epriestley 2020-04-29 14:41:28 -07:00
parent b648a85841
commit 186a12ef7f
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/infrastructure/diff/viewstate/PhabricatorChangesetViewStateEngine.php
View file

@ -197,7 +197,7 @@ final class PhabricatorChangesetViewStateEngine
$entries = isort($entries, 'epoch'); $entries = isort($entries, 'epoch');
if ($entries) { if ($entries) {
$other_phid = last_key($entries); $other_key = last_key($entries);
$other_spec = last($entries); $other_spec = last($entries);
$this_version = (int)$changeset->getDiffID(); $this_version = (int)$changeset->getDiffID();
@ -213,7 +213,7 @@ final class PhabricatorChangesetViewStateEngine
$other_changeset = id(new DifferentialChangesetQuery()) $other_changeset = id(new DifferentialChangesetQuery())
->setViewer($viewer) ->setViewer($viewer)
->withPHIDs(array($other_phid)) ->withIDs(array($other_key))
->executeOne(); ->executeOne();
$is_modified = false; $is_modified = false;