From 18e0ee079132d1a63464db817109f17b1347ce5e Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Tue, 19 May 2015 11:48:02 -0700 Subject: [PATCH] Transactions - move TYPE_SUBSCRIBERS to require optional implementation Summary: Ref T6403. This one was pretty easy since no one does anything custom with subscribers. Test Plan: subscribed / unscribed to a random commit ("audit"). joined / left, watched / unwatched a project Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin, epriestley Maniphest Tasks: T6403 Differential Revision: https://secure.phabricator.com/D12930 --- src/applications/audit/editor/PhabricatorAuditEditor.php | 2 -- .../calendar/editor/PhabricatorCalendarEventEditor.php | 2 -- .../differential/editor/DifferentialTransactionEditor.php | 2 -- src/applications/fund/editor/FundInitiativeEditor.php | 2 -- src/applications/paste/editor/PhabricatorPasteEditor.php | 2 -- .../project/editor/PhabricatorProjectTransactionEditor.php | 3 --- .../editor/PhabricatorApplicationTransactionEditor.php | 3 ++- 7 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/applications/audit/editor/PhabricatorAuditEditor.php b/src/applications/audit/editor/PhabricatorAuditEditor.php index 77d1d0a23a..f3e7bdebb0 100644 --- a/src/applications/audit/editor/PhabricatorAuditEditor.php +++ b/src/applications/audit/editor/PhabricatorAuditEditor.php @@ -116,7 +116,6 @@ final class PhabricatorAuditEditor switch ($xaction->getTransactionType()) { case PhabricatorTransactions::TYPE_COMMENT: - case PhabricatorTransactions::TYPE_SUBSCRIBERS: case PhabricatorAuditActionConstants::ACTION: case PhabricatorAuditActionConstants::INLINE: case PhabricatorAuditActionConstants::ADD_AUDITORS: @@ -133,7 +132,6 @@ final class PhabricatorAuditEditor switch ($xaction->getTransactionType()) { case PhabricatorTransactions::TYPE_COMMENT: - case PhabricatorTransactions::TYPE_SUBSCRIBERS: case PhabricatorAuditActionConstants::ACTION: case PhabricatorAuditTransaction::TYPE_COMMIT: return; diff --git a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php index cf6fc5936e..3e3b68d08f 100644 --- a/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php +++ b/src/applications/calendar/editor/PhabricatorCalendarEventEditor.php @@ -111,7 +111,6 @@ final class PhabricatorCalendarEventEditor case PhabricatorTransactions::TYPE_COMMENT: case PhabricatorTransactions::TYPE_VIEW_POLICY: case PhabricatorTransactions::TYPE_EDIT_POLICY: - case PhabricatorTransactions::TYPE_SUBSCRIBERS: return; } @@ -153,7 +152,6 @@ final class PhabricatorCalendarEventEditor case PhabricatorTransactions::TYPE_COMMENT: case PhabricatorTransactions::TYPE_VIEW_POLICY: case PhabricatorTransactions::TYPE_EDIT_POLICY: - case PhabricatorTransactions::TYPE_SUBSCRIBERS: return; } diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php index a9084093f6..24ffbb9031 100644 --- a/src/applications/differential/editor/DifferentialTransactionEditor.php +++ b/src/applications/differential/editor/DifferentialTransactionEditor.php @@ -195,7 +195,6 @@ final class DifferentialTransactionEditor case PhabricatorTransactions::TYPE_EDIT_POLICY: $object->setEditPolicy($xaction->getNewValue()); return; - case PhabricatorTransactions::TYPE_SUBSCRIBERS: case PhabricatorTransactions::TYPE_COMMENT: case DifferentialTransaction::TYPE_INLINE: return; @@ -578,7 +577,6 @@ final class DifferentialTransactionEditor case PhabricatorTransactions::TYPE_VIEW_POLICY: case PhabricatorTransactions::TYPE_EDIT_POLICY: return; - case PhabricatorTransactions::TYPE_SUBSCRIBERS: case PhabricatorTransactions::TYPE_COMMENT: case DifferentialTransaction::TYPE_ACTION: return; diff --git a/src/applications/fund/editor/FundInitiativeEditor.php b/src/applications/fund/editor/FundInitiativeEditor.php index 33ad1017d0..13296be13f 100644 --- a/src/applications/fund/editor/FundInitiativeEditor.php +++ b/src/applications/fund/editor/FundInitiativeEditor.php @@ -102,7 +102,6 @@ final class FundInitiativeEditor $object->setTotalAsCurrency($total); return; - case PhabricatorTransactions::TYPE_SUBSCRIBERS: case PhabricatorTransactions::TYPE_VIEW_POLICY: case PhabricatorTransactions::TYPE_EDIT_POLICY: return; @@ -155,7 +154,6 @@ final class FundInitiativeEditor $editor->applyTransactions($backer, $subx); return; - case PhabricatorTransactions::TYPE_SUBSCRIBERS: case PhabricatorTransactions::TYPE_VIEW_POLICY: case PhabricatorTransactions::TYPE_EDIT_POLICY: return; diff --git a/src/applications/paste/editor/PhabricatorPasteEditor.php b/src/applications/paste/editor/PhabricatorPasteEditor.php index 86f2eea393..0d64017421 100644 --- a/src/applications/paste/editor/PhabricatorPasteEditor.php +++ b/src/applications/paste/editor/PhabricatorPasteEditor.php @@ -89,7 +89,6 @@ final class PhabricatorPasteEditor $object->setEditPolicy($xaction->getNewValue()); return; case PhabricatorTransactions::TYPE_COMMENT: - case PhabricatorTransactions::TYPE_SUBSCRIBERS: return; } @@ -107,7 +106,6 @@ final class PhabricatorPasteEditor case PhabricatorTransactions::TYPE_VIEW_POLICY: case PhabricatorTransactions::TYPE_EDIT_POLICY: case PhabricatorTransactions::TYPE_COMMENT: - case PhabricatorTransactions::TYPE_SUBSCRIBERS: return; } diff --git a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php index 84ca63a358..348ba53c4d 100644 --- a/src/applications/project/editor/PhabricatorProjectTransactionEditor.php +++ b/src/applications/project/editor/PhabricatorProjectTransactionEditor.php @@ -102,8 +102,6 @@ final class PhabricatorProjectTransactionEditor case PhabricatorProjectTransaction::TYPE_LOCKED: $object->setIsMembershipLocked($xaction->getNewValue()); return; - case PhabricatorTransactions::TYPE_SUBSCRIBERS: - return; case PhabricatorTransactions::TYPE_VIEW_POLICY: $object->setViewPolicy($xaction->getNewValue()); return; @@ -159,7 +157,6 @@ final class PhabricatorProjectTransactionEditor } return; - case PhabricatorTransactions::TYPE_SUBSCRIBERS: case PhabricatorTransactions::TYPE_VIEW_POLICY: case PhabricatorTransactions::TYPE_EDIT_POLICY: case PhabricatorTransactions::TYPE_JOIN_POLICY: diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php index 406aaeac4a..11c11e1cc9 100644 --- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php +++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php @@ -401,6 +401,7 @@ abstract class PhabricatorApplicationTransactionEditor case PhabricatorTransactions::TYPE_CUSTOMFIELD: $field = $this->getCustomFieldForTransaction($object, $xaction); return $field->applyApplicationTransactionInternalEffects($xaction); + case PhabricatorTransactions::TYPE_SUBSCRIBERS: case PhabricatorTransactions::TYPE_INLINESTATE: case PhabricatorTransactions::TYPE_EDGE: return $this->applyBuiltinInternalTransaction($object, $xaction); @@ -441,8 +442,8 @@ abstract class PhabricatorApplicationTransactionEditor $xaction->getOldValue(), $xaction->getNewValue())); $this->subscribers = $subscribers; + return $this->applyBuiltinExternalTransaction($object, $xaction); - break; case PhabricatorTransactions::TYPE_EDGE: if ($this->getIsInverseEdgeEditor()) { // If we're writing an inverse edge transaction, don't actually