From 18e1bd2e459d16d537ac1c2a2b70fd1a2146e5fb Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Thu, 2 Jul 2015 14:25:45 -0700
Subject: [PATCH] [Redesign] Clean up <select>

Summary: Ref T8099, Ref T8449. Adds a min width to selects (can't think of anything this breaks in ui) and adds space around space select.

Test Plan: Review a number of selects in different UIs, forms, dialogs.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099, T8449

Differential Revision: https://secure.phabricator.com/D13523
---
 resources/celerity/map.php                         |  6 +++---
 src/view/form/control/AphrontFormPolicyControl.php |  1 +
 webroot/rsrc/css/phui/phui-form.css                | 11 ++++++++++-
 3 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index c20f4fe690..fc9718efd5 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => 'a7580731',
+    'core.pkg.css' => '7f52c50a',
     'core.pkg.js' => 'a590b451',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => '73f1d1bc',
@@ -133,7 +133,7 @@ return array(
     'rsrc/css/phui/phui-feed-story.css' => 'c7d8113a',
     'rsrc/css/phui/phui-fontkit.css' => 'cb8ae7ad',
     'rsrc/css/phui/phui-form-view.css' => '621b21c5',
-    'rsrc/css/phui/phui-form.css' => '17ce37a9',
+    'rsrc/css/phui/phui-form.css' => 'afdb2c6e',
     'rsrc/css/phui/phui-header-view.css' => '4d09d68f',
     'rsrc/css/phui/phui-icon.css' => '88ba9081',
     'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
@@ -775,7 +775,7 @@ return array(
     'phui-feed-story-css' => 'c7d8113a',
     'phui-font-icon-base-css' => '3dad2ae3',
     'phui-fontkit-css' => 'cb8ae7ad',
-    'phui-form-css' => '17ce37a9',
+    'phui-form-css' => 'afdb2c6e',
     'phui-form-view-css' => '621b21c5',
     'phui-header-view-css' => '4d09d68f',
     'phui-icon-view-css' => '88ba9081',
diff --git a/src/view/form/control/AphrontFormPolicyControl.php b/src/view/form/control/AphrontFormPolicyControl.php
index 0d95fc4a53..4201091d2b 100644
--- a/src/view/form/control/AphrontFormPolicyControl.php
+++ b/src/view/form/control/AphrontFormPolicyControl.php
@@ -351,6 +351,7 @@ final class AphrontFormPolicyControl extends AphrontFormControl {
         $space_phid),
       array(
         'name' => 'spacePHID',
+        'class' => 'aphront-space-select-control-knob',
       ));
 
     return $select;
diff --git a/webroot/rsrc/css/phui/phui-form.css b/webroot/rsrc/css/phui/phui-form.css
index a6c73117b8..cb8c0a7752 100644
--- a/webroot/rsrc/css/phui/phui-form.css
+++ b/webroot/rsrc/css/phui/phui-form.css
@@ -107,8 +107,9 @@ input[type="checkbox"] {
 select {
   height: 24px;
   line-height: 24px;
-  border: 1px solid #a1a5a9;
+  border: 1px solid {$lightgreyborder};
   background-color: #ffffff;
+  min-width: 140px;
 }
 
 select[multiple],
@@ -144,3 +145,11 @@ select[disabled],
 input[disabled] {
   opacity: 0.5;
 }
+
+.aphront-space-select-control-knob {
+  margin: 2px 8px 2px 0;
+}
+
+.device .aphront-space-select-control-knob {
+  margin-bottom: 8px;
+}