revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-25 22:18:19 +01:00
Code Issues Releases Wiki Activity

Fix a bug with "Resign" in Diffusion

Browse source 
Summary: The PHID list is a list, not a map -- I must have broken this in refactoring or something, since everything else works fine. See D2013.

Test Plan: Viewed a resignable revision, saw "Resign" (new after this commit), resignd.

Reviewers: 20after4, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T904

Differential Revision: https://secure.phabricator.com/D2417
This commit is contained in:
epriestley 2012-05-07 13:37:41 -07:00
parent c58bd95842
commit 191f6d904f
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/diffusion/controller/commit/DiffusionCommitController.php
View file

@ -604,8 +604,10 @@ final class DiffusionCommitController extends DiffusionController {
// commit's author. // commit's author.
if (!$user_is_author) { if (!$user_is_author) {
$may_resign = false; $may_resign = false;
$authority_map = array_fill_keys($this->auditAuthorityPHIDs, true);
foreach ($audit_requests as $request) { foreach ($audit_requests as $request) {
if (empty($this->auditAuthorityPHIDs[$request->getAuditorPHID()])) { if (empty($authority_map[$request->getAuditorPHID()])) {
continue; continue;
} }
$may_resign = true; $may_resign = true;