From 1922590f98b5f1a4d163103c3619dff391c1ebaf Mon Sep 17 00:00:00 2001 From: Bob Trahan Date: Fri, 7 Dec 2012 12:00:28 -0800 Subject: [PATCH] fix fluid diff change Summary: when we had a change that had new data and uncommitted changes the colspan could get off. make sure to only decrement the colspan if we are actually on a new line Test Plan: http://phabricator.dev/rP1a3bf098ae4ab4f8add4af744a6b93a257851fb0 now looks good on Firefox Reviewers: vrana, epriestley Reviewed By: epriestley CC: aran, Korvin Maniphest Tasks: T2005 Differential Revision: https://secure.phabricator.com/D4109 --- .../differential/parser/DifferentialChangesetParser.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/applications/differential/parser/DifferentialChangesetParser.php b/src/applications/differential/parser/DifferentialChangesetParser.php index d7abf2948b..8567481207 100644 --- a/src/applications/differential/parser/DifferentialChangesetParser.php +++ b/src/applications/differential/parser/DifferentialChangesetParser.php @@ -1552,7 +1552,6 @@ final class DifferentialChangesetParser { $n_colspan--; } - if ($this->new[$ii]['type']) { if ($this->new[$ii]['type'] == '\\') { $n_text = $this->new[$ii]['text']; @@ -1590,8 +1589,8 @@ final class DifferentialChangesetParser { ), ''); } + $n_colspan--; } - $n_colspan--; } $n_classes .= ' right'.$n_colspan;