revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-20 13:52:40 +01:00
Code Issues Releases Wiki Activity

Fix audit counts in some queries

Browse source 
Summary:
Prior to D5140, "PhabricatorAuditCommitQuery::STATUS_OPEN" was defined as "concern only". This didn't really make sense; we redefined it to "concern or audit required".

However, a couple of queries needed to be updated since they really meant "concern" even though they said "open".

I also switch the order of problem commits / audit required on the Audit homepage to be consistent with the bubbles on home.

Test Plan: Looked at home, /audit/.

Reviewers: chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5162
This commit is contained in:
epriestley 2013-02-28 15:01:32 -08:00
parent 57cce93e5a
commit 19d67b778d
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/audit/application/PhabricatorApplicationAudit.php
View file

@ -51,7 +51,7 @@ final class PhabricatorApplicationAudit extends PhabricatorApplication {
$commits = id(new PhabricatorAuditCommitQuery()) $commits = id(new PhabricatorAuditCommitQuery())
->withAuthorPHIDs($phids) ->withAuthorPHIDs($phids)
->withStatus(PhabricatorAuditQuery::STATUS_OPEN) ->withStatus(PhabricatorAuditCommitQuery::STATUS_CONCERN)
->execute(); ->execute();
$count = count($commits); $count = count($commits);

4
src/applications/audit/controller/PhabricatorAuditListController.php
View file

@ -271,8 +271,8 @@ final class PhabricatorAuditListController extends PhabricatorAuditController {
$views = array(); $views = array();
switch ($this->filter) { switch ($this->filter) {
case 'active': case 'active':
$views[] = $this->buildAuditView($handle);
$views[] = $this->buildCommitView($handle); $views[] = $this->buildCommitView($handle);
$views[] = $this->buildAuditView($handle);
break; break;
case 'audits': case 'audits':
case 'user': case 'user':
@ -455,7 +455,7 @@ final class PhabricatorAuditListController extends PhabricatorAuditController {
switch ($this->filter) { switch ($this->filter) {
case 'active': case 'active':
$query->withStatus(PhabricatorAuditCommitQuery::STATUS_OPEN); $query->withStatus(PhabricatorAuditCommitQuery::STATUS_CONCERN);
break; break;
default: default:
switch ($this->filterStatus) { switch ($this->filterStatus) {