1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-27 16:00:59 +01:00

Surface custom form instructions as a "Remarkup" field for the transaction layer

Summary: Ref T13263. See <https://discourse.phabricator-community.org/t/image-uploads-for-forms-too-restricted-by-default/2594>. Currently, when you add instructions to a custom form, we don't expose them as remarkup, so `{Fxxx}` references don't get attached correctly and won't get proper permissions.

Test Plan:
Dragged-and-dropped an image into form instructions, saw the file attach to the form:

{F6367710}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13263

Differential Revision: https://secure.phabricator.com/D20387
This commit is contained in:
epriestley 2019-04-10 09:34:03 -07:00
parent 9e65e6c503
commit 1a52c8f713

View file

@ -149,5 +149,19 @@ final class PhabricatorEditEngineConfigurationTransaction
return parent::getIcon();
}
protected function newRemarkupChanges() {
$changes = array();
$type = $this->getTransactionType();
switch ($type) {
case self::TYPE_PREAMBLE:
$changes[] = $this->newRemarkupChange()
->setOldValue($this->getOldValue())
->setNewValue($this->getNewValue());
break;
}
return $changes;
}
}