From 1a92976c144fd8d8bfe46123c9d1e44a568466c2 Mon Sep 17 00:00:00 2001 From: Anh Nhan Nguyen Date: Mon, 18 Mar 2013 10:37:40 -0400 Subject: [PATCH] Deduplicating duplicated field values for Commit Messages / Differential Summary: Especially when doing 'arc diff' containing multiple commits which have pre-filled template fields. Names would pop up multiple times Test Plan: {F36314} Local `arc diff` with some uber-branch also agrees with me Reviewers: epriestley, vrana Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5371 --- .../field/specification/DifferentialCCsFieldSpecification.php | 2 +- .../DifferentialManiphestTasksFieldSpecification.php | 2 +- .../specification/DifferentialReviewersFieldSpecification.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php b/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php index 1af5fedd59..932b1c7bff 100644 --- a/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php +++ b/src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php @@ -73,7 +73,7 @@ final class DifferentialCCsFieldSpecification } public function setValueFromParsedCommitMessage($value) { - $this->ccs = nonempty($value, array()); + $this->ccs = array_unique(nonempty($value), array()); return $this; } diff --git a/src/applications/differential/field/specification/DifferentialManiphestTasksFieldSpecification.php b/src/applications/differential/field/specification/DifferentialManiphestTasksFieldSpecification.php index 9ff4e8e860..4af92b55ec 100644 --- a/src/applications/differential/field/specification/DifferentialManiphestTasksFieldSpecification.php +++ b/src/applications/differential/field/specification/DifferentialManiphestTasksFieldSpecification.php @@ -92,7 +92,7 @@ final class DifferentialManiphestTasksFieldSpecification } public function setValueFromParsedCommitMessage($value) { - $this->maniphestTasks = nonempty($value, array()); + $this->maniphestTasks = array_unique(nonempty($value), array()); return $this; } diff --git a/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php b/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php index 45a20da245..fedc06df6f 100644 --- a/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php +++ b/src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php @@ -91,7 +91,7 @@ final class DifferentialReviewersFieldSpecification } public function setValueFromParsedCommitMessage($value) { - $this->reviewers = nonempty($value, array()); + $this->reviewers = array_unique(nonempty($value), array()); return $this; }