revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 17:22:42 +01:00
Code Issues Releases Wiki Activity

Herald queries correctly label Object Rules

Browse source 
Summary: Fixes T7730. Herald queries used to incorrectly label object rules as global rules. An object rule is now labeled as such.

Test Plan: Made a few rules and looked at the herald query page.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T7730

Differential Revision: https://secure.phabricator.com/D12259
This commit is contained in:
Elan Kugelmass 2015-04-02 05:00:39 -07:00 committed by epriestley
parent 8e5153e866
commit 1ae1cdd7ba
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/herald/query/HeraldRuleSearchEngine.php
View file

@ -186,6 +186,8 @@ final class HeraldRuleSearchEngine extends PhabricatorApplicationSearchEngine {
pht( pht(
'Authored by %s', 'Authored by %s',
$handles[$rule->getAuthorPHID()]->renderLink())); $handles[$rule->getAuthorPHID()]->renderLink()));
} else if ($rule->isObjectRule()) {
$item->addIcon('fa-briefcase', pht('Object Rule'));
} else { } else {
$item->addIcon('fa-globe', pht('Global Rule')); $item->addIcon('fa-globe', pht('Global Rule'));
} }