From 1b2c047ce0df730f3d87bf7b65a9957fd1d7acac Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 27 Feb 2017 04:04:35 -0800 Subject: [PATCH] Correct spelling of "phabrictor" in Lipsum and elsewhere Summary: Ref T12319. The product name is misspelled in some methods, and a few places in the documentation. Test Plan: `grep` Reviewers: chad Reviewed By: chad Maniphest Tasks: T12319 Differential Revision: https://secure.phabricator.com/D17419 --- .../PhabricatorDifferentialRevisionTestDataGenerator.php | 4 ++-- .../files/lipsum/PhabricatorFileTestDataGenerator.php | 2 +- .../lipsum/generator/PhabricatorTestDataGenerator.php | 7 ++----- .../lipsum/PhabricatorManiphestTaskTestDataGenerator.php | 6 +++--- .../lipsum/PhabricatorPholioMockTestDataGenerator.php | 4 ++-- src/docs/contributor/phabricator_code_layout.diviner | 2 +- src/docs/user/configuration/advanced_configuration.diviner | 2 +- src/docs/user/userguide/audit.diviner | 2 +- src/docs/user/userguide/projects.diviner | 2 +- 9 files changed, 14 insertions(+), 17 deletions(-) diff --git a/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php b/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php index 737db1aef8..70f79309fd 100644 --- a/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php +++ b/src/applications/differential/lipsum/PhabricatorDifferentialRevisionTestDataGenerator.php @@ -8,7 +8,7 @@ final class PhabricatorDifferentialRevisionTestDataGenerator } public function generateObject() { - $author = $this->loadPhabrictorUser(); + $author = $this->loadPhabricatorUser(); $revision = DifferentialRevision::initializeNewRevision($author); $revision->attachReviewerStatus(array()); @@ -39,7 +39,7 @@ final class PhabricatorDifferentialRevisionTestDataGenerator public function getCCPHIDs() { $ccs = array(); for ($i = 0; $i < rand(1, 4);$i++) { - $ccs[] = $this->loadPhabrictorUserPHID(); + $ccs[] = $this->loadPhabricatorUserPHID(); } return $ccs; } diff --git a/src/applications/files/lipsum/PhabricatorFileTestDataGenerator.php b/src/applications/files/lipsum/PhabricatorFileTestDataGenerator.php index cf084d32a7..c1daa0dea4 100644 --- a/src/applications/files/lipsum/PhabricatorFileTestDataGenerator.php +++ b/src/applications/files/lipsum/PhabricatorFileTestDataGenerator.php @@ -8,7 +8,7 @@ final class PhabricatorFileTestDataGenerator } public function generateObject() { - $author_phid = $this->loadPhabrictorUserPHID(); + $author_phid = $this->loadPhabricatorUserPHID(); $dimension = 1 << rand(5, 12); $image = id(new PhabricatorLipsumMondrianArtist()) ->generate($dimension, $dimension); diff --git a/src/applications/lipsum/generator/PhabricatorTestDataGenerator.php b/src/applications/lipsum/generator/PhabricatorTestDataGenerator.php index 2617c755df..fe784dcb10 100644 --- a/src/applications/lipsum/generator/PhabricatorTestDataGenerator.php +++ b/src/applications/lipsum/generator/PhabricatorTestDataGenerator.php @@ -89,9 +89,6 @@ abstract class PhabricatorTestDataGenerator extends Phobject { return $xaction; } - - - public function loadOneRandom($classname) { try { return newv($classname, array()) @@ -106,11 +103,11 @@ abstract class PhabricatorTestDataGenerator extends Phobject { } } - public function loadPhabrictorUserPHID() { + public function loadPhabricatorUserPHID() { return $this->loadOneRandom('PhabricatorUser')->getPHID(); } - public function loadPhabrictorUser() { + public function loadPhabricatorUser() { return $this->loadOneRandom('PhabricatorUser'); } diff --git a/src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php b/src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php index 5b52aaa480..50a1df77c0 100644 --- a/src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php +++ b/src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php @@ -8,7 +8,7 @@ final class PhabricatorManiphestTaskTestDataGenerator } public function generateObject() { - $author_phid = $this->loadPhabrictorUserPHID(); + $author_phid = $this->loadPhabricatorUserPHID(); $author = id(new PhabricatorUser()) ->loadOneWhere('phid = %s', $author_phid); $task = ManiphestTask::initializeNewTask($author) @@ -63,7 +63,7 @@ final class PhabricatorManiphestTaskTestDataGenerator public function getCCPHIDs() { $ccs = array(); for ($i = 0; $i < rand(1, 4);$i++) { - $ccs[] = $this->loadPhabrictorUserPHID(); + $ccs[] = $this->loadPhabricatorUserPHID(); } return $ccs; } @@ -83,7 +83,7 @@ final class PhabricatorManiphestTaskTestDataGenerator if (rand(0, 3) == 0) { return null; } else { - return $this->loadPhabrictorUserPHID(); + return $this->loadPhabricatorUserPHID(); } } diff --git a/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php b/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php index ac61327b39..9a274443cf 100644 --- a/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php +++ b/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php @@ -8,7 +8,7 @@ final class PhabricatorPholioMockTestDataGenerator } public function generateObject() { - $author_phid = $this->loadPhabrictorUserPHID(); + $author_phid = $this->loadPhabricatorUserPHID(); $author = id(new PhabricatorUser()) ->loadOneWhere('phid = %s', $author_phid); $mock = PholioMock::initializeNewMock($author); @@ -82,7 +82,7 @@ final class PhabricatorPholioMockTestDataGenerator public function getCCPHIDs() { $ccs = array(); for ($i = 0; $i < rand(1, 4);$i++) { - $ccs[] = $this->loadPhabrictorUserPHID(); + $ccs[] = $this->loadPhabricatorUserPHID(); } return $ccs; } diff --git a/src/docs/contributor/phabricator_code_layout.diviner b/src/docs/contributor/phabricator_code_layout.diviner index 19ec048f73..422f228a27 100644 --- a/src/docs/contributor/phabricator_code_layout.diviner +++ b/src/docs/contributor/phabricator_code_layout.diviner @@ -55,7 +55,7 @@ this document. See @{article:Adding New CSS and JS}.) phabricator/webroot/rsrc/css/application/derp/ These directories under `phabricator/src/applications/derp/` represent -the basic set of class types from which most Phabrictor applications are +the basic set of class types from which most Phabricator applications are assembled. Each would contain a class file. For `Derp`, these classes could be something like: diff --git a/src/docs/user/configuration/advanced_configuration.diviner b/src/docs/user/configuration/advanced_configuration.diviner index 17212ad4ee..5721ffd597 100644 --- a/src/docs/user/configuration/advanced_configuration.diviner +++ b/src/docs/user/configuration/advanced_configuration.diviner @@ -79,7 +79,7 @@ a config like this: To select a configuration file, write the name of the file (relative to `phabricator/conf/`) to `phabricator/conf/local/ENVIRONMENT`. For example, to select `phabricator/conf/custom/exampleconfig.conf.php`, you would write -"custom/exampleconfig" to `phabrictor/conf/local/ENVIRONMENT`: +"custom/exampleconfig" to `phabricator/conf/local/ENVIRONMENT`: phabricator/ $ echo custom/exampleconfig > conf/local/ENVIRONMENT phabricator/ $ cat conf/local/ENVIRONMENT diff --git a/src/docs/user/userguide/audit.diviner b/src/docs/user/userguide/audit.diviner index 806d37adab..0d10867906 100644 --- a/src/docs/user/userguide/audit.diviner +++ b/src/docs/user/userguide/audit.diviner @@ -59,7 +59,7 @@ a typical audit workflow: - Alice publishes a commit containing some Javascript. - This triggers an audit request to Bailey, the Javascript technical lead on the project (see below for a description of trigger mechanisms). - - Later, Bailey logs into Phabrictor and sees the audit request. She ignores + - Later, Bailey logs into Phabricator and sees the audit request. She ignores it for the moment, since it isn't blocking anything. At the end of the week she looks through her open requests to see what the team has been up to. diff --git a/src/docs/user/userguide/projects.diviner b/src/docs/user/userguide/projects.diviner index 6f29e3586c..573c8c4c69 100644 --- a/src/docs/user/userguide/projects.diviner +++ b/src/docs/user/userguide/projects.diviner @@ -37,7 +37,7 @@ only members of the "Backend" project, nor does it allow them to see it if they otherwise could not. Likewise, removing projects does not affect visibility. If you're familiar with other software that works differently, this may be -unexpected, but the rule in Phabrictor is simple: **adding and removing +unexpected, but the rule in Phabricator is simple: **adding and removing projects never affects policies.** Note that you //can// write policy rules which restrict capabilities to members