From 1b4015d2c1ff9d79001a8ee516d98890b2064481 Mon Sep 17 00:00:00 2001 From: Andre Klapper Date: Sun, 7 May 2023 12:35:30 +0200 Subject: [PATCH] Fix PHP 8.1 "strlen(null)" exception which blocks rendering Pholio mock preview Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Closes T15353 Test Plan: Applied this change and `/pholio/create/` displayed an image preview after uploading an image file. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15353 Differential Revision: https://we.phorge.it/D25193 --- .../pholio/controller/PholioImageUploadController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/pholio/controller/PholioImageUploadController.php b/src/applications/pholio/controller/PholioImageUploadController.php index 0ff5e061f5..44d7ea7eed 100644 --- a/src/applications/pholio/controller/PholioImageUploadController.php +++ b/src/applications/pholio/controller/PholioImageUploadController.php @@ -18,7 +18,7 @@ final class PholioImageUploadController extends PholioController { return new Aphront404Response(); } - if (!strlen($title)) { + if (!phutil_nonempty_string($title)) { $title = $file->getName(); }