From 1bcc8a3d98e00ab4b8c260038d4f2e6f51174fb0 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 19 Jan 2017 12:51:54 -0800 Subject: [PATCH] Remove timeline from Profile Manage Summary: Not sure this page is really providing any value, the timeline always says "edited this object" and there is a list of actions. Seems we could move actions back to the profile proper, but they feel very... engineery to me. Or we could fix the timeline stories, but my guess is they aren't useful or we would have gotten such feedback. Test Plan: Review manage page, timeline is gone. Page is clean. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D17230 --- .../PhabricatorPeopleProfileManageController.php | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/applications/people/controller/PhabricatorPeopleProfileManageController.php b/src/applications/people/controller/PhabricatorPeopleProfileManageController.php index c5a3ceabd4..ba533c041c 100644 --- a/src/applications/people/controller/PhabricatorPeopleProfileManageController.php +++ b/src/applications/people/controller/PhabricatorPeopleProfileManageController.php @@ -45,11 +45,6 @@ final class PhabricatorPeopleProfileManageController $nav = $this->getProfileMenu(); $nav->selectFilter(PhabricatorPeopleProfileMenuEngine::ITEM_MANAGE); - $timeline = $this->buildTransactionTimeline( - $user, - new PhabricatorPeopleTransactionQuery()); - $timeline->setShouldTerminate(true); - $crumbs = $this->buildApplicationCrumbs(); $crumbs->addTextCrumb(pht('Manage')); $crumbs->setBorder(true); @@ -57,11 +52,7 @@ final class PhabricatorPeopleProfileManageController $manage = id(new PHUITwoColumnView()) ->setHeader($header) ->setCurtain($curtain) - ->addPropertySection(pht('Details'), $properties) - ->setMainColumn( - array( - $timeline, - )); + ->addPropertySection(pht('Details'), $properties); return $this->newPage() ->setTitle(