Modernize Herald

Summary: Updates Herald to use modern methods.

Test Plan: View List, View Test Console, Run a test, View Results, View Rules, New Rule, Edit Rule, Check mobile menus.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T9690

Differential Revision: https://secure.phabricator.com/D14596

src/applications/herald/controller/HeraldController.php

@@ -18,22 +18,17 @@ abstract class HeraldController extends PhabricatorController {
     return $crumbs;
   }
 
-  public function buildSideNavView($for_app = false) {
+  public function buildSideNavView() {
-    $user = $this->getRequest()->getUser();
+    $viewer = $this->getViewer();
 
     $nav = new AphrontSideNavFilterView();
     $nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
 
-    if ($for_app) {
-      $nav->addFilter('new', pht('Create Rule'));
-    }
-
     id(new HeraldRuleSearchEngine())
-      ->setViewer($user)
+      ->setViewer($viewer)
       ->addNavigationItems($nav->getMenu());
 
-    $nav
+    $nav->addLabel(pht('Utilities'))
-      ->addLabel(pht('Utilities'))
         ->addFilter('test', pht('Test Console'))
         ->addFilter('transcript', pht('Transcripts'));
 

src/applications/herald/controller/HeraldNewController.php

@@ -206,13 +206,14 @@ final class HeraldNewController extends HeraldController {
       ->buildApplicationCrumbs()
       ->addTextCrumb(pht('Create Rule'));
 
-    return $this->buildApplicationPage(
+    $title = pht('Create Herald Rule');
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild(
         array(
-        $crumbs,
           $form_box,
-      ),
-      array(
-        'title' => pht('Create Herald Rule'),
       ));
   }
 

src/applications/herald/controller/HeraldRuleController.php

@@ -247,13 +247,14 @@ final class HeraldRuleController extends HeraldController {
       ->buildApplicationCrumbs()
       ->addTextCrumb($title);
 
-    return $this->buildApplicationPage(
+    $title = pht('Edit Rule');
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild(
         array(
-        $crumbs,
           $form_box,
-      ),
-      array(
-        'title' => pht('Edit Rule'),
       ));
   }
 

src/applications/herald/controller/HeraldRuleViewController.php

@@ -49,14 +49,15 @@ final class HeraldRuleViewController extends HeraldController {
       new HeraldTransactionQuery());
     $timeline->setShouldTerminate(true);
 
-    return $this->buildApplicationPage(
+    $title = $rule->getName();
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild(
         array(
-        $crumbs,
           $object_box,
           $timeline,
-      ),
-      array(
-        'title' => $rule->getName(),
       ));
   }
 

src/applications/herald/controller/HeraldTestConsoleController.php

@@ -102,19 +102,19 @@ final class HeraldTestConsoleController extends HeraldController {
       ->setFormErrors($errors)
       ->setForm($form);
 
-    $nav = $this->buildSideNavView();
-    $nav->selectFilter('test');
-    $nav->appendChild($box);
-
     $crumbs = id($this->buildApplicationCrumbs())
       ->addTextCrumb(pht('Test Console'));
-    $nav->setCrumbs($crumbs);
 
-    return $this->buildApplicationPage(
+    $title = pht('Test Console');
-      $nav,
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild(
         array(
-        'title' => pht('Test Console'),
+          $box,
       ));
+
   }
 
 }

src/applications/herald/controller/HeraldTranscriptController.php

@@ -81,13 +81,14 @@ final class HeraldTranscriptController extends HeraldController {
         $this->getApplicationURI('/transcript/'))
       ->addTextCrumb($xscript->getID());
 
-    return $this->buildApplicationPage(
+    $title = pht('Transcript');
+
+    return $this->newPage()
+      ->setTitle($title)
+      ->setCrumbs($crumbs)
+      ->appendChild(
         array(
-        $crumbs,
           $content,
-      ),
-      array(
-        'title' => pht('Transcript'),
       ));
   }
 

src/applications/herald/controller/HeraldTranscriptListController.php

@@ -2,16 +2,12 @@
 
 final class HeraldTranscriptListController extends HeraldController {
 
-  public function buildSideNavView($for_app = false) {
+  public function buildSideNavView() {
     $user = $this->getRequest()->getUser();
 
     $nav = new AphrontSideNavFilterView();
     $nav->setBaseURI(new PhutilURI($this->getApplicationURI()));
 
-    if ($for_app) {
-      $nav->addFilter('new', pht('Create Rule'));
-    }
-
     id(new HeraldTranscriptSearchEngine())
       ->setViewer($user)
       ->addNavigationItems($nav->getMenu());
@@ -31,14 +27,9 @@ final class HeraldTranscriptListController extends HeraldController {
   }
 
   public function handleRequest(AphrontRequest $request) {
-    $querykey = $request->getURIData('queryKey');
+    return id(new HeraldTranscriptSearchEngine())
-
+      ->setController($this)
-    $controller = id(new PhabricatorApplicationSearchController())
+      ->buildResponse();
-      ->setQueryKey($querykey)
-      ->setSearchEngine(new HeraldTranscriptSearchEngine())
-      ->setNavigation($this->buildSideNavView());
-
-    return $this->delegateToController($controller);
   }
 
 }

src/applications/herald/query/HeraldTranscriptSearchEngine.php

@@ -76,7 +76,7 @@ final class HeraldTranscriptSearchEngine
 
   protected function getBuiltinQueryNames() {
     return array(
-      'all' => pht('All'),
+      'all' => pht('All Transcripts'),
     );
   }