1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00

In Conpherence, stop throwing away stuff users have typed when a reply arrives

Summary:
Ref T12562. I think the pre-send-on-enter behavior was: disable textarea, send message, clear area on response?

That got changed but not completely, maybe. There's currently an issue here:

  - Add a `sleep(3)` to `UpdateController`.
  - Type "AAA".
  - Press enter.
  - Real fast, type "BBB".
  - When the "AAA" arrives, your "BBB" is lost. Sad!

Test Plan:
  - Did the thing described above; no longer lost "BBB".
  - Switched threads, sent messages, couldn't find anything else this breaks. It dates from a long time ago so I think it's just pre-SOE stuff.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12562

Differential Revision: https://secure.phabricator.com/D17742
This commit is contained in:
epriestley 2017-04-19 17:02:52 -07:00
parent 7a992b5488
commit 1c222c8834
2 changed files with 17 additions and 18 deletions

View file

@ -8,7 +8,7 @@
return array(
'names' => array(
'conpherence.pkg.css' => '3776e82d',
'conpherence.pkg.js' => '5f86c17d',
'conpherence.pkg.js' => '7b6aa581',
'core.pkg.css' => '959330a2',
'core.pkg.js' => '47a69358',
'darkconsole.pkg.js' => '1f9a31bc',
@ -378,7 +378,7 @@ return array(
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '4d863052',
'rsrc/js/application/conpherence/behavior-conpherence-search.js' => '9bbf3762',
'rsrc/js/application/conpherence/behavior-durable-column.js' => 'aa3bd034',
'rsrc/js/application/conpherence/behavior-menu.js' => '80dda04a',
'rsrc/js/application/conpherence/behavior-menu.js' => '31ab6d0f',
'rsrc/js/application/conpherence/behavior-participant-pane.js' => '8604caa8',
'rsrc/js/application/conpherence/behavior-pontificate.js' => '55616e04',
'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3',
@ -605,7 +605,7 @@ return array(
'javelin-behavior-choose-control' => '327a00d1',
'javelin-behavior-comment-actions' => '9a6dd75c',
'javelin-behavior-config-reorder-fields' => 'b6993408',
'javelin-behavior-conpherence-menu' => '80dda04a',
'javelin-behavior-conpherence-menu' => '31ab6d0f',
'javelin-behavior-conpherence-participant-pane' => '8604caa8',
'javelin-behavior-conpherence-pontificate' => '55616e04',
'javelin-behavior-conpherence-search' => '9bbf3762',
@ -1126,6 +1126,20 @@ return array(
'31420f77' => array(
'javelin-behavior',
),
'31ab6d0f' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-workflow',
'javelin-behavior-device',
'javelin-history',
'javelin-vector',
'javelin-scrollbar',
'phabricator-title',
'phabricator-shaped-request',
'conpherence-thread-manager',
),
'320810c8' => array(
'javelin-install',
'javelin-dom',
@ -1532,20 +1546,6 @@ return array(
'javelin-vector',
'javelin-stratcom',
),
'80dda04a' => array(
'javelin-behavior',
'javelin-dom',
'javelin-util',
'javelin-stratcom',
'javelin-workflow',
'javelin-behavior-device',
'javelin-history',
'javelin-vector',
'javelin-scrollbar',
'phabricator-title',
'phabricator-shaped-request',
'conpherence-thread-manager',
),
'834a1173' => array(
'javelin-behavior',
'javelin-scrollbar',

View file

@ -70,7 +70,6 @@ JX.behavior('conpherence-menu', function(config) {
var textarea = JX.DOM.find(form_root, 'textarea');
if (!non_update) {
_scrollMessageWindow();
textarea.value = '';
}
markThreadLoading(false);