revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 13:30:55 +01:00
Code Issues Releases Wiki Activity

Object selector does live-updates without requiring user to hit 'search'

Browse source 
Summary:
Editing Maniphest tasks for a Differential Revision required user to hit
'search' every time he changed search parameters. Now select and text input
changes trigger search automatically.

Test Plan:
Tested that changing the select and entering text automatically gave the
correct results.

Reviewed By: epriestley
Reviewers: epriestley, jungejason
Commenters: jungejason
CC: epriestley, jungejason
Differential Revision: 102
This commit is contained in:
tuomaspelkonen 2011-04-05 14:16:49 -07:00
parent c72d9980d5
commit 1c6487197f
2 changed files with 23 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/view/control/objectselector/PhabricatorObjectSelectorDialog.php
View file

@ -101,9 +101,6 @@ class PhabricatorObjectSelectorDialog {
<td class="phabricator-object-selector-search-text">
<input type="text" id="'.$query_id.'" />
</td>
<td class="phabricator-object-selector-search-button">
<button>Search</button>
</td>
</tr>
</table>');
$result_box =

41
webroot/rsrc/js/application/core/behavior-object-selector.js
View file

@ -12,6 +12,8 @@ JX.behavior('phabricator-object-selector', function(config) {
phids[k] = true;
}
var attach_list = {};
var query_timer = null;
var query_delay = 50;
var phid_input = JX.DOM.find(
JX.$(config.form),
@ -94,6 +96,7 @@ JX.behavior('phabricator-object-selector', function(config) {
}
function sendQuery() {
query_timer = null;
JX.DOM.setContent(JX.$(config.results), renderNote('Loading...'))
new JX.Request(config.uri, JX.bind(null, onreceive, ++n))
.setData({
@ -103,24 +106,6 @@ JX.behavior('phabricator-object-selector', function(config) {
.send();
}
JX.DOM.listen(
JX.$(config.search),
'submit',
null,
function(e) {
e.kill();
sendQuery();
});
JX.DOM.listen(
JX.$(config.search),
'click',
'tag:button',
function(e) {
e.kill();
sendQuery();
});
JX.DOM.listen(
JX.$(config.results),
'click',
@ -162,6 +147,26 @@ JX.behavior('phabricator-object-selector', function(config) {
redrawAttached();
});
JX.DOM.listen(
JX.$(config.filter),
'change',
null,
function(e) {
e.kill();
sendQuery();
});
JX.DOM.listen(
JX.$(config.query),
'keydown',
null,
function(e) {
if (query_timer) {
query_timer.stop();
}
query_timer = JX.defer(sendQuery, query_delay);
});
sendQuery();
redrawAttached();