1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 22:40:55 +01:00

Fix issue with ref/fixes in commit messages

Summary: Fixes T4600. If there's also a revision, the variable "$message" gets overwritten. groan~

Test Plan: Pushed a commit with "Fixes T123" and a revision, saw it parse on the first try.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: chrisbolt, aran, epriestley

Maniphest Tasks: T4600

Differential Revision: https://secure.phabricator.com/D8519
This commit is contained in:
epriestley 2014-03-13 17:47:11 -07:00
parent 29436dfe37
commit 1d30354223

View file

@ -128,13 +128,13 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
$actor);
if ($committer_name && ($committer_name != $author_name)) {
$message = pht(
$revision_update_comment = pht(
'Closed by commit %s (authored by %s, committed by %s).',
$commit_name,
$author_name,
$committer_name);
} else {
$message = pht(
$revision_update_comment = pht(
'Closed by commit %s (authored by %s).',
$commit_name,
$author_name);
@ -170,7 +170,7 @@ abstract class PhabricatorRepositoryCommitMessageParserWorker
->setIgnoreOnNoEffect(true)
->attachComment(
id(new DifferentialTransactionComment())
->setContent($message));
->setContent($revision_update_comment));
$content_source = PhabricatorContentSource::newForSource(
PhabricatorContentSource::SOURCE_DAEMON,