1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 05:20:56 +01:00

Fix overzealous subscribing in EditEngine

Summary:
See T9905#148799. The CommentEditField generated empty comment transactions; these are dropped later, but before they are dropped they would trigger implicit CCs.

The implicit CC rule should probably be narrower, but we shouldn't be generating these transactions in the first place.

Test Plan: No longer implicitly CC'd on a task when doing something minor like changing projects.

Reviewers: chad

Reviewed By: chad

Subscribers: avivey

Differential Revision: https://secure.phabricator.com/D14795
This commit is contained in:
epriestley 2015-12-15 16:10:04 -08:00
parent 4b3dcd5500
commit 1d72c97fc9

View file

@ -11,6 +11,10 @@ final class PhabricatorCommentEditField
return new PhabricatorCommentEditType();
}
public function shouldGenerateTransactionsFromSubmit() {
return false;
}
public function shouldGenerateTransactionsFromComment() {
return true;
}