revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 12:52:42 +01:00
Code Issues Releases Wiki Activity

Clean up some tablet issues with new nav layouts

Browse source 
Summary: Makes sidenav disappear again on projects/profiles, but shows it on home again (tablet views).

Test Plan: Visit Profile/Projects/Home on mobile, desktop, and tablet. See nav disappear correctly.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D16369
This commit is contained in:
Chad Little 2016-08-04 20:49:16 +00:00 committed by chad
parent 8f4a63d708
commit 1dd9c37fdf
4 changed files with 16 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
resources/celerity/map.php
View file

@ -7,7 +7,7 @@
*/
return array(
'names' => array(
'core.pkg.css' => '6b69c820',
'core.pkg.css' => '90c46327',
'core.pkg.js' => 'b562c3db',
'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => '3fb7f532',
@ -24,7 +24,7 @@ return array(
'rsrc/css/aphront/multi-column.css' => 'fd18389d',
'rsrc/css/aphront/notification.css' => '3f6c89c9',
'rsrc/css/aphront/panel-view.css' => '8427b78d',
'rsrc/css/aphront/phabricator-nav-view.css' => '9a498cb0',
'rsrc/css/aphront/phabricator-nav-view.css' => '09f3d0db',
'rsrc/css/aphront/table-view.css' => '832656fd',
'rsrc/css/aphront/tokenizer.css' => '056da01b',
'rsrc/css/aphront/tooltip.css' => '1a07aea8',
@ -122,7 +122,7 @@ return array(
'rsrc/css/phui/phui-action-list.css' => 'c5eba19d',
'rsrc/css/phui/phui-action-panel.css' => '91c7b835',
'rsrc/css/phui/phui-badge.css' => '3baef8db',
'rsrc/css/phui/phui-basic-nav-view.css' => 'bfc71dd0',
'rsrc/css/phui/phui-basic-nav-view.css' => '7093573b',
'rsrc/css/phui/phui-big-info-view.css' => 'bd903741',
'rsrc/css/phui/phui-box.css' => '5c8387cf',
'rsrc/css/phui/phui-button.css' => '4a5fbe3d',
@ -786,7 +786,7 @@ return array(
'phabricator-keyboard-shortcut' => '1ae869f2',
'phabricator-keyboard-shortcut-manager' => '4a021c10',
'phabricator-main-menu-view' => 'b623169f',
'phabricator-nav-view-css' => '9a498cb0',
'phabricator-nav-view-css' => '09f3d0db',
'phabricator-notification' => 'ccf1cbf8',
'phabricator-notification-css' => '3f6c89c9',
'phabricator-notification-menu-css' => 'f31c0bde',
@ -825,7 +825,7 @@ return array(
'phriction-document-css' => '4282e4ad',
'phui-action-panel-css' => '91c7b835',
'phui-badge-view-css' => '3baef8db',
'phui-basic-nav-view-css' => 'bfc71dd0',
'phui-basic-nav-view-css' => '7093573b',
'phui-big-info-view-css' => 'bd903741',
'phui-box-css' => '5c8387cf',
'phui-button-css' => '4a5fbe3d',

1
src/applications/home/controller/PhabricatorHomeMainController.php
View file

@ -53,6 +53,7 @@ final class PhabricatorHomeMainController extends PhabricatorHomeController {
return $this->newPage()
->setTitle('Phabricator')
->addClass('phabricator-home')
->appendChild($content);
}

6
webroot/rsrc/css/aphront/phabricator-nav-view.css
View file

@ -7,7 +7,9 @@
}
.device-desktop .has-closed-nav div.phabricator-nav-local,
.device-desktop .has-closed-nav div.phabricator-nav-drag {
.device-desktop .has-closed-nav div.phabricator-nav-drag,
.device .phui-navigation-shell div.phabricator-nav-local,
.device .phui-navigation-shell div.phabricator-nav-drag {
display: none;
}
@ -16,7 +18,7 @@
display: block;
}
.device .phabricator-side-menu-home .phabricator-nav-local {
.device-phone .phabricator-side-menu-home .phabricator-nav-local {
display: block;
}

9
webroot/rsrc/css/phui/phui-basic-nav-view.css
View file

@ -2,17 +2,20 @@
* @provides phui-basic-nav-view-css
*/
.device-desktop .phui-navigation-shell {
.device-desktop .phui-navigation-shell,
.phabricator-home.device .phui-navigation-shell {
display: table;
width: 100%;
height: calc(100vh - {$menu.main.height});
}
.device-desktop .phui-navigation-shell .phabricator-nav {
.device-desktop .phui-navigation-shell .phabricator-nav,
.phabricator-home.device .phui-navigation-shell .phabricator-nav {
display: table-row;
}
.device-desktop .phui-navigation-shell .phabricator-nav-local {
.device-desktop .phui-navigation-shell .phabricator-nav-local,
.phabricator-home.device .phui-navigation-shell .phabricator-nav-local {
display: table-cell;
position: relative;
vertical-align: top;